Better error handling

[isomorpheme]

Right now, a lot of errors are returned using Option. I think it's more idiomatic and user friendly if errors are returned using Result, because then consumers of this library can use the error information to do their own error reporting, or handle an error gracefully. Currently the code handling errors just does hardcoded println!s, which is only unwanted output IMO, and causes information loss. It should be pretty simple to change uses of Option<T> to Result<T, &str> or something similar, and I'm willing to make a pull request for it.

[jhasse]

Fully agree :) Thanks for working on this.

[vimalloc]

+1

If I can find some time in the next couple months I would be happy to help with this as well.

[jhasse]

I think @ijks already pushed some of his changes here: https://github.com/ijks/ears/tree/better-error-handling

Looking forward to it! :)

[vimalloc]

Thanks for the link! I'll see if I can coordinate with him :)

[isomorpheme]

So this fell a bit by the wayside. 😅 I think what I had so far was pretty much done, or at least covered all cases where functions used to panic. So I could just open a PR? It's all Result<T, String> though. It might be nicer to be more idiomatic and use a proper error type (using e.g. error-chain or quick-error). But that's probably best left to another PR.

[jhasse]

Yes, just open a PR :)