Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from team-73-the-corgis #4

Open
canriquez opened this issue Apr 24, 2020 · 0 comments
Open

Feedback from team-73-the-corgis #4

canriquez opened this issue Apr 24, 2020 · 0 comments

Comments

@canriquez
Copy link

  • Good progress on the page. You are almost there!
  • If you need to go fast, repeating images is a way to go.
  • Nevertheless, this project (also Newsweek and the HTML capstone) is a good portfolio showcase so you might consider include the complete set of pictures. It will take time, but definitely will stand out. You could come back later (at portfolio time) but it will be a pain to update all pictures then...
  • Footer icons: You could use font awesome icons and place them in a UL
<ul>
    <li><a href="#"><i class="fab fa-facebook-square"></i></a></li>
    <li><a href="#"><i class="fab fa-twitter"></i></a></li>
    <li><a href="#"><i class="fab fa-youtube"></i></a></li>
    <li><a href="#"><i class="fab fa-instagram"></i></a></li>
    <li><a href="#"><i class="fab fa-pinterest-p"></i></a></li>
    <li><a href="#"><i class="fas fa-rss"></i></a></li>
    <li><a href="#"><i class="far fa-envelope"></i></a></li>
</ul>

. The other option is to copy the SVG code into each <li> and use fill property on CSS to change the color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant