Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback from team-73-the-corgis #5

Open
Jhdezj opened this issue Apr 28, 2020 · 0 comments
Open

Feedback from team-73-the-corgis #5

Jhdezj opened this issue Apr 28, 2020 · 0 comments

Comments

@Jhdezj
Copy link
Owner

Jhdezj commented Apr 28, 2020 •
edited
Loading

1.- Things missing so far:

  • Links
  • Code cleaning and validation
  • Readme file update
  • Transitions

2.- Check out for semantics because there is a section with no h1. Use a class to hide it by using display none. https://gsnedders.html5.org/outliner/
3.- Adjust the queries on the footer section for mobile. You have twice the Facebook icon. There should be only 6 instead of 7.
4.- Use span elements in the footer section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jhdezj