Adds check for first query param for deltaBundleId #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
unfortunately this breaks persisting breakpoints |
cryptodev523
pushed a commit
to cryptodev523/react-native-debugger
that referenced
this pull request
Jan 27, 2022
* Adds check for first query param for deltaBundleId * Fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've an issue where requests would be made to
http://127.0.0.1:8081/index.ios.delta&deltaBundleId=f629f67b2d9863a7(using&instead of?for the first query param) resulting in a 404 and then a red screen whenever you reload the app after connecting to React Native Debugger.This PR checks if a query param already exists and instead appends a second param to bypass this issue.