Add getMax to fetch maximum/native resolution #33
+43
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the _compareCFDisplayModes method uses CGDisplayModeRef* as the first and second parameters, in alignment with the CFComparatorFunction type alias declaration expecting an UnsafeRawPointer. But CGDisplayModeRef is already a pointer to CGDisplayMode and doesn't need a reference again to work as a comparator. Doing so also introduces extra referencing and dereferencing that can be avoided. Update the method signature to pass CGDisplayModeRef directly.
Newer versions of MacOS use a scaling factor (like 2x, which is the default for newer MacBooks), leading to the default mode being half the native resolution of the display. In such cases, it would be desirable to fetch the maximum resolution supported by the display (native resolution). Add a getMax option to fetch this information.
|
Quick note: I have little to no experience with C, much less Apple Dev tools. I have been using the neofetch script for years, which depends on this library, and has lately been showing incorrect resolutions due to Apple's latest changes. So rather than adding workarounds, I wanted to add support for this at the source, if possible. Please do let me know if this could have been done in a better way, as well as major code improvements. |
|
@jhford gentle nudge to review when you can : ) |
|
Bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fetch max supported mode for each monitor
Newer versions of MacOS use a scaling factor (like 2x, which is the
default for newer MacBooks), leading to the default mode being half the
native resolution of the display. In such cases, it would be desirable
to fetch the maximum resolution supported by the display (native
resolution).
Add a getMax option to fetch this information.
Avoid de-reference in _compareCFDisplayModes
Currently, the
_compareCFDisplayModesmethod usesCGDisplayModeRef*as the first and second parameters, in alignment with the
CFComparatorFunctiontype alias declaration expecting anUnsafeRawPointer. ButCGDisplayModeRefis already a pointer toCGDisplayModeand doesn't need a reference again to work as acomparator. Doing so also introduces extra referencing and dereferencing
that can be avoided.