Upgrade to JHipster 7 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2021
mraible
commented
May 11, 2021
generators/app/index.js
Outdated
| @@ -50,6 +50,7 @@ module.exports = class extends BaseGenerator { | |||
|
|
|||
| this.interactive = this.options.interactive; | |||
| this.installDeps = this.options.installDeps; | |||
| this.conflicter = this.conflicter || this.env.conflicter; | |||
There was a problem hiding this comment.
@mshima I'm not sure this is working. When I npm link and run yo jhipster-ionic, I get the following error:
force backend/.yo-rc.json
Error jhipster-ionic
Cannot set property 'force' of undefined
There was a problem hiding this comment.
@mraible is there a reason to don't merge https://github.com/mraible/generator-jhipster-ionic/pull/49?
There was a problem hiding this comment.
this.env.conflicter isn't instantiated at this moment.
There was a problem hiding this comment.
@mshima I never saw your PR! That's why I didn't merge. It looks like there are some conflicts. I'll merge if you resolve.
This reverts commit 51296e6.
Conflicts: generators/entity-client/index.js
Jhipster 7
Fix CRUD generation and e2e tests
Fix force with yo@4/environment@3
Fix force using environment 3
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466.