-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to extend the app sub-generator in blueprints #9692
Comments
I don't think we have a ticket for that. I remember a private discussion about doing a blueprint for app generator. I understand your problem @arjunnayak I have the same one for a company blueprint. |
I'm a bit puzzled with this request (and I don't remember having already discussed it): by overriding the app subgenerator you can really change the full jhipster behavior, since this subgenerator is orchestrating the other subgenerators ( But why not, we could try. I also wonder what @deepu105 thinks about it. |
As mentioned in the description, our main concern is simplifying the prompts. At this time, we don’t have other needs to override the app generator. For example, we have our own front end generator based on create-react-app, so there’s no need to even prompt for application type since our blueprint is only used for generating micro services. Is it possible to move these prompts to a separate generator? That may lessen the potential for messing up crucial functionality happening in the app generator. Just a thought |
having pre and post prompt sub generators could be a way to do this. Another solution for you could be having your own jhipster online (the original one is open source too) and remove the fields you don't need (application type for exemple) then it generates a .yo-rc.json and call your blueprint. Every prompt you want to skip will be fill up in the .yo-rc by the jhipster online. I assume it change the way you use your generators. |
Hello, |
After thinking more about it, I think we should do it. |
@murdos which of the two approach are you talking about? being able to override steps in the app-generator and give full control to the blueprint author or just limit certain options? |
Give full control, by making |
thanks @murdos |
Thanks @murdos, let us know how we can help! |
@murdos do keep in mind that app generator is the main entry point which composes others so extending it could be tricky. If you need any help let me know |
FYI I just unassigned from this ticket since it's indeed more tricky than what I initially thought and I don't plan to work on this soon. |
Hi all, However, we can do that as option in the jhipster cli instead to implement it in all blueprints: we can run jhipster with (for example) --add-yo-rc option, in order to give a specific yo-rc.json path, specially for the first generation (or the second that overrides that created before in the generation folder) |
My easy solution for the app generator customization is in #10482 |
Close by #10752 |
Overview of the feature request
While we can extend majority of the sub-generators in a blueprint, it would be great to have the option to extend the others, namely the app generator.
Motivation for or Use Case
In the interest of developer experience at our company, we're trying to simplify as much of the blueprint process as possible. In our case, this involves making modifications to questions that we can't control like type of application, internationalization, testing frameworks, installing other modules from jhipster marketplace, etc. Is this possible, or is there a technical limitation around this?
Related issues or PR
The text was updated successfully, but these errors were encountered: