ng-jhipster migration to generator-jhipster

[kaidohallik]

This PR removes ng-jhipster dependency from generator-jhipster.

Closes #12909

This PR contains commits from https://github.com/jhipster/ng-jhipster extracted by method described in #12909 (comment)

Probably not all ng-jhipster committers from period 2016-2020 are signed CLA, so probably needs to be merged without passing CLA check.

As we have strict TypeScript option and TypeScript ESLint "plugin:@typescript-eslint/recommended-requiring-type-checking" then I was forced to do quite a lot changes to get migrated functionality to work in generator-jhipster.

Some comments about changes by commits.

sort

In the process of migration fixed #12868

metrics

• split code to .ts and .html as Angular style guide suggests
• declared also model, so fixed one "@typescript-eslint/no-explicit-any" as referenced also in Strict Typescript option in metrics module in Angular #10873 (comment)
• used ChangeDetectionStrategy.OnPush where functions was used in html - performance improved a bit
• improved filter section in threads modal window - instead of showing filter in text input, badges are now directly reflecting current filtering state
• temporarily added -new to component selectors to avoid conflicts with ng-jhipster, those are removed by the ng-jhipster removal commit

event-manager

In jhipster/ng-jhipster#115 I made preparation to simplify output to event manager consumers - return only event.content because event name is redundant, subscription is by name. But now we have #12778 - multiple subscriptions, it's a good idea and in this case returning full info, including event name, is must have. So I deleted this simplification preparation and we should go #12778 way.

jhi-boolean

As this is used only in one place, user management detail view (and if skipping user management, for example oauth2, then there is 0 usages), and if this component is not widely used and it's API learned then code without this component is better understandable, so I didn't migrate this component but instead using simple html in user management detail view (lines used in .ejs template reduced from 10 to 2).

jhi-item-count

Temporarily added -new to component selector to avoid conflicts with ng-jhipster, this is removed by the ng-jhipster removal commit.

As in current implementation:

• HTML was hacked and very ugly to put somehow i18n disabled and enabled to work together in one component
• perfomance was bad, every event in page caused recalculation of jhi-item-count (for example every click resulted with 6 time recalculation)
• calculation was implemented twice, one for i18n enabled and other for i18n disabled
• if i18n disabled then calculation was not unit tested

Then rewrote component, now:

• HTML is now very minimalistic 1-liner (achieved by using enableTranslation variable available in generator)
• item-count component is recalculated only if input changes (different page is selected)
• common calculation for both i18n disabled and enabled
• as there is common solution for i18n disabled and enabled then both are now also unit tested

data-util

• removed unused functionality and tests for unused functionality (a lot was removed)
• openFile function has 2 forks, comment was that the first one is for IE and Edge, but for Edge that was not true, so changed comment from "To support IE and Edge" to "To support IE"

parse-links

Polished and made shorter

alert.service

Now when we have full control over this component (we can use powerful if (enableTranslation) { ... }) we should refactor this service to offer better API to avoid hacky workarounds as described in closing #12796. But this enhancement is out of scope of this PR.

translate

• in this commit removed also ng-jhipster dependency
• now we don't need to force @ngx-translate dependency for i18n disabled any more
• after removing ng-jhipster dependency, core.module is quite small and after merging this PR I want to move code from core.module to app.module and delete core.module to reduce code hierarchy level

---

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• jhipster-online was updated if necessary
• Documentation is added/updated where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 9 committers have signed the CLA.

✅ deepu105
✅ wmarques
✅ jdubois
✅ vishal423
✅ kaidohallik
✅ SudharakaP
✅ mshima
✅ pascalgrimaud
❌ Vivek More

---

Vivek More seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[pascalgrimaud]

really good job @kaidohallik !
I'm trusting you here, and unless someone wants to review it, I'll probably merge it really soon

[mshima]

I have tested yesterday, and everything looks fine, I forgot to test sorting.
One thing I've noticed it that the UI does not change to the account language once logged in, but I don't know if it's a regression.

Bundle at our ngx-default changed from:

chunk {2} main.2c37efdf00f81a130127.css, main.9268b221dd8c8f2aad31.js (main) 853 kB [initial] [rendered]
64

to

chunk {2} main.2c37efdf00f81a130127.css, main.83dd4bcfd4386bf44784.js (main) 801 kB [initial] [rendered]
63

IMO let's merge, and finish testing it in main branch.

[kaidohallik]

One thing I've noticed it that the UI does not change to the account language once logged in, but I don't know if it's a regression.

I tested this and this was working for me. You probably changed language before logging in? Logic in application is: if user has changed language then in this session don't change language on login any more.

[kaidohallik]

Thanks @mshima for merging!

[kaidohallik]

Bounty claimed https://opencollective.com/generator-jhipster/expenses/28314

[pascalgrimaud]

@kaidohallik : approved