-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix insecure random source for tokens #185
fix insecure random source for tokens #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits.
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
Now the tests are failing because of unrelated changes. We will have to fix the build now. |
Give me a ping in case I can help testing. |
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
I got |
Chrome can't be started. I have tested it with latest jhipster version and it worked fine locally. Should we merge this regardless of the failing tests? |
@atomfrede Sorry for taking too long to reply. It is due to 6.3's mismatch in dependency. Can you base this PR against |
@sendilkumarn Sure will do. Give me until tomorrow. |
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
31af38e
to
d74a665
Compare
Done and rebased. |
3a35af5
to
efdf40a
Compare
closes #183