fix insecure random source for tokens #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendilkumarn
approved these changes
Sep 15, 2019
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
|
Now the tests are failing because of unrelated changes. We will have to fix the build now. |
|
Give me a ping in case I can help testing. |
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/main/kotlin/package/service/util/RandomUtil.kt.ejs
Outdated
Show resolved
Hide resolved
|
I got |
|
Chrome can't be started. I have tested it with latest jhipster version and it worked fine locally. Should we merge this regardless of the failing tests? |
|
@atomfrede Sorry for taking too long to reply. It is due to 6.3's mismatch in dependency. Can you base this PR against |
|
@sendilkumarn Sure will do. Give me until tomorrow. |
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
…il/RandomUtil.kt.ejs Co-Authored-By: Sendil Kumar N <sendilkumarn@live.com>
atomfrede
force-pushed
the
183-port-cwe-fix-to-kotlin
branch
from
31af38e
to
d74a665
Compare
|
Done and rebased. |
sendilkumarn
force-pushed
the
move-to-6.3
branch
from
3a35af5
to
efdf40a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #183