-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zuul support, and allow monitoring of all services from the Registry #99
Comments
Also we should be able to display instances metadata, that I implemented in : jhipster/generator-jhipster#5221 I have created a mockup for some ideas I have for the admin panel design. Of course you will also need an overview screen. Sorry I don't have time to participate, good luck to the interns working on this. |
I'm on the first task.
|
First task is done :-) |
I've commit the health page. All requests concerning instances are routed correctly. By default, the Registry "instance" is selected. You can launch some gateway/microservices, refresh, etc... Do you want a PR, or do you prefer that I continue to code on other pages (config, logs and metrics) now ? EDIT : I will add more comments and javadoc on my code |
@JulienMrgrd Do you force a reload when switching services ? |
No, but indeed, we must do it. |
With this commit, we can see instances status. |
@JulienMrgrd Also recently I added instance metadata about registered applications (version, profile, etc.). Can you display it somewhere, maybe in the main "Application" tab. |
It concerns this PR ? Fix for displaying Consul instances and metadata #5170 I finish on the metrics page, and after I'll add this ;) |
Yes, it's this one. |
It's done @PierreBesson ;) Just a little problem with the badge's css, I don't know why. As @jdubois said about registry, when the entire Angular 2/4 migration (and this issue) will be finished, we should apply a good layer of design/UX-UI. |
@JulienMrgrd, Nice ! Don't worry about the alignment issue. It can be fixed later. |
Logs page OK. The last page, "configuration", is in progress... We may have to found a solution to reduce the loading time of logs. It's a little bit slow :/ Note : As we work on same files, the PR #106 (by @g-boy05 and @heronakam) should be merge before mine. |
ok we look with @heronakam on this |
I think you can try to add infinitescroll for logs
Thanks & Regards,
Deepu
…On Thu, Apr 6, 2017 at 6:29 PM, g-boy05 ***@***.***> wrote:
ok we look with @heronakam <https://github.com/heronakam> on this
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDlFz8GV8hFwaeuTzpf5ExKXKQwFACmks5rtRLjgaJpZM4MHOAl>
.
|
…g Cloud Configuration : old = "Configuration", now = "Cloud config")
Issue #99 Zuul support and switchable services in Admin pages
About the instance selection, are you OK (@jhipster/registry-developers) with something like that ? : A Dropdown menu, with all instances grouped by application. The item is blue when you hover it (no mouse on screenshots 🐭). I'm working on a typeahead/search input to reduce the number of instances (always by thinking of a registry that can visualize a hundred of instances). EDIT : Or something like that : https://codepen.io/skywalkapps/full/YwRvyY/ |
@JulienMrgrd yes that would be very nice. I myself didnt like our current pills/tab selector as its not salable. Please go ahead and PR it 👍 |
The second task of this issue is now OK with the PR #120.
|
@JulienMrgrd I will showing your work on the registry tomorrow during my presentation in Rennes. It's just too good ! 🎉 |
@PierreBesson My "monitoringServicesZuul" branch (on my fork) is up-to-date (Angular 4, zuul, routes in admin, and the dropdown). https://github.com/JulienMrgrd/registry/tree/monitoringServicesZuul |
Closing as only the last point is missing, but we'll do this later (first we have a stable registry, then we remove the screens) |
/services/{application-name}/api/management
The text was updated successfully, but these errors were encountered: