Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zuul support, and allow monitoring of all services from the Registry #99

Closed
2 of 3 tasks
jdubois opened this issue Feb 21, 2017 · 21 comments
Closed
2 of 3 tasks
Projects

Comments

@jdubois
Copy link
Member

jdubois commented Feb 21, 2017

  • Add Zuul support to the Registry, so it can route requests to microservices/gateways/monoliths. The URL would be in the form /services/{application-name}/api/management
  • When Upgrade the front-end to Angular 2 #98 is done, have a full "Admin" menu, that uses an internal Zuul to access each microservice, gateway and monolith. Each "admin" entry will have a top drop-down list (like we have currently on Swagger for gateways), where the service can be selected.
  • Make the "admin" menu optional on the gateways and monoliths (as they can be monitored with the Registry)
@jdubois jdubois added this to TODO in Release 3.0 Feb 21, 2017
@PierreBesson
Copy link
Contributor

PierreBesson commented Feb 21, 2017

Also we should be able to display instances metadata, that I implemented in : jhipster/generator-jhipster#5221

I have created a mockup for some ideas I have for the admin panel design.

untitled diagram

Of course you will also need an overview screen. Sorry I don't have time to participate, good luck to the interns working on this.

@JulienMrgrd
Copy link
Member

I'm on the first task.

  • Add Zuul support to the Registry, so it can route requests to microservices/gateways/monoliths. The URL would be in the form /services/{application-name}/api/management

@jdubois
Copy link
Member Author

jdubois commented Mar 24, 2017

First task is done :-)

JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Mar 30, 2017
@JulienMrgrd
Copy link
Member

JulienMrgrd commented Mar 30, 2017

I've commit the health page. All requests concerning instances are routed correctly.
Normally, i've checked that there is no warning concerning the back and the front. As I start on Angular 2, there are probably some improvements to apply.

By default, the Registry "instance" is selected. You can launch some gateway/microservices, refresh, etc...

Do you want a PR, or do you prefer that I continue to code on other pages (config, logs and metrics) now ?

EDIT : I will add more comments and javadoc on my code

EDIT 2 : Actual view
capture d ecran de 2017-03-31 10-50-51

@PierreBesson
Copy link
Contributor

@JulienMrgrd Do you force a reload when switching services ?

@JulienMrgrd
Copy link
Member

No, but indeed, we must do it.
There is no error displayed or "down" tag actually.

JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Mar 30, 2017
@JulienMrgrd
Copy link
Member

With this commit, we can see instances status.
And, as @PierreBesson has proposed, instances switching provoke a refresh of routes.
(and I've remove some warnings, again)

@PierreBesson
Copy link
Contributor

@JulienMrgrd Also recently I added instance metadata about registered applications (version, profile, etc.). Can you display it somewhere, maybe in the main "Application" tab.

@JulienMrgrd
Copy link
Member

It concerns this PR ? Fix for displaying Consul instances and metadata #5170

I finish on the metrics page, and after I'll add this ;)

@PierreBesson
Copy link
Contributor

Yes, it's this one.

JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Mar 31, 2017
JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Mar 31, 2017
JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Apr 4, 2017
@JulienMrgrd
Copy link
Member

It's done @PierreBesson ;)

capture d ecran de 2017-04-04 14-44-00

Just a little problem with the badge's css, I don't know why.
Maybe an update in package.json ?

As @jdubois said about registry, when the entire Angular 2/4 migration (and this issue) will be finished, we should apply a good layer of design/UX-UI.

@PierreBesson
Copy link
Contributor

@JulienMrgrd, Nice ! Don't worry about the alignment issue. It can be fixed later.

JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Apr 6, 2017
@JulienMrgrd
Copy link
Member

JulienMrgrd commented Apr 6, 2017

Logs page OK. The last page, "configuration", is in progress...

We may have to found a solution to reduce the loading time of logs. It's a little bit slow :/

Note : As we work on same files, the PR #106 (by @g-boy05 and @heronakam) should be merge before mine.

@g-boy05
Copy link
Contributor

g-boy05 commented Apr 6, 2017

ok we look with @heronakam on this

@deepu105
Copy link
Member

deepu105 commented Apr 6, 2017 via email

JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Apr 10, 2017
JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Apr 10, 2017
…g Cloud Configuration : old = "Configuration", now = "Cloud config")
jdubois added a commit that referenced this issue Apr 11, 2017
Issue #99 Zuul support and switchable services in Admin pages
This was referenced Apr 12, 2017
@JulienMrgrd
Copy link
Member

JulienMrgrd commented Apr 19, 2017

About the instance selection, are you OK (@jhipster/registry-developers) with something like that ? :

capture d ecran de 2017-04-19 12-19-21

capture d ecran de 2017-04-19 12-19-28

A Dropdown menu, with all instances grouped by application. The item is blue when you hover it (no mouse on screenshots 🐭).

I'm working on a typeahead/search input to reduce the number of instances (always by thinking of a registry that can visualize a hundred of instances).
We could, for example, search by instance or app name.

EDIT : Or something like that : https://codepen.io/skywalkapps/full/YwRvyY/

@deepu105
Copy link
Member

@JulienMrgrd yes that would be very nice. I myself didnt like our current pills/tab selector as its not salable. Please go ahead and PR it 👍

JulienMrgrd added a commit to JulienMrgrd/Jhipster-Registry that referenced this issue Apr 20, 2017
@JulienMrgrd
Copy link
Member

The second task of this issue is now OK with the PR #120.


  • Add Zuul support to the Registry, so it can route requests to microservices/gateways/monoliths. The URL would be in the form /services/{application-name}/api/management

  • When Upgrade the front-end to Angular 2 #98 is done, have a full "Admin" menu, that uses an internal Zuul to access each microservice, gateway and monolith. Each "admin" entry will have a top drop-down list (like we have currently on Swagger for gateways), where the service can be selected.

@PierreBesson
Copy link
Contributor

@JulienMrgrd I will showing your work on the registry tomorrow during my presentation in Rennes. It's just too good ! 🎉
Can you do a temporary branch on your fork that includes everything you've done until now. It needs to be ready for tomorrow 14h30.

@JulienMrgrd
Copy link
Member

@PierreBesson My "monitoringServicesZuul" branch (on my fork) is up-to-date (Angular 4, zuul, routes in admin, and the dropdown).

https://github.com/JulienMrgrd/registry/tree/monitoringServicesZuul

@jdubois
Copy link
Member Author

jdubois commented Apr 27, 2017

Closing as only the last point is missing, but we'll do this later (first we have a stable registry, then we remove the screens)

@jdubois jdubois closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants