Angular4 upgrade #118
Angular4 upgrade #118
Conversation
| "clientPackageManager": "yarn" | ||
| } | ||
| } | ||
| "generator-jhipster": { |
| "jwtSecretKey": "c9d37cefc48581919939d587c750ea215020765b", | ||
| "useSass": false, | ||
| "enableTranslation": false, | ||
| "applicationType": "microservice", |
There was a problem hiding this comment.
I think making application type to gateway would be more appropriate
| @@ -6,7 +6,7 @@ | |||
| <artifactId>spring-boot-starter-parent</artifactId> | |||
| <groupId>org.springframework.boot</groupId> | |||
| <version>1.5.2.RELEASE</version> | |||
| <relativePath/> | |||
| <relativePath /> | |||
| @NgModule({ | ||
| imports: [ | ||
| JhipsterRegistrySharedModule, | ||
| RouterModule.forRoot(adminState, {useHash: true}) | ||
| RouterModule.forRoot(adminState, { useHash: true }), | ||
| NgbModule.forRoot(), |
There was a problem hiding this comment.
why this import, its already imported by JhipsterRegistrySharedModule and hence should be available here?
| <h4 class="modal-title" id="showHealthLabel"><span class="text-capitalize">{{ baseName(currentHealth.name) }}</span> | ||
| {{subSystemName(currentHealth.name)}} | ||
| </h4> | ||
| {{subSystemName(currentHealth.name)}}</span></h4> |
There was a problem hiding this comment.
format this part properly so that span and h4 are in new lines
| @@ -11,12 +11,22 @@ Metrics page styles | |||
| text-align: initial; | |||
| } | |||
|
|
|||
| span.label { /* UP, DOWN, ... */ | |||
| /* ========================================================================== | |||
| Routes styles | |||
There was a problem hiding this comment.
why is this called route styles?
Please move this into the main app css and make it class and apply it everywhere instead of duplicating this everywhere
There was a problem hiding this comment.
do the same for all common styles
| @@ -10,7 +10,7 @@ | |||
| <ul class="list-group"> | |||
There was a problem hiding this comment.
this code seems to be used in many components. It should be made into a re usable component and then included everywhere
| if (index !== -1) { | ||
| this.routes[index].status = 'DOWN'; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // user click | ||
| getLabelClassRoute(route: Route) { | ||
| getBadgeClassRoute(route: Route) { |
There was a problem hiding this comment.
same for the duplicated methods. these should go into the reusable componenet
| @@ -33,6 +33,14 @@ <h4 class="modal-title">Sign in</h4> | |||
| </div> | |||
| <button type="submit" class="btn btn-primary">Sign in</button> | |||
| </form> | |||
| <p></p> | |||
| <div class="alert alert-warning"> | |||
There was a problem hiding this comment.
Are these required? as we dont have a user management for registry
|
I'm working on this. I'll merge it manually @JulienMrgrd @mohamed2a @jhipster/registry-developers please do not change generated code unless there is a need for it as it will make upgrades harder. If you find an issue in the generated code fix it at root (In the generator) |
|
@jdubois could you please wait for my review for new PR's? |
|
Yes of course |
|
I have refactored the front end code a bit. I have pushed it but its WIP. I'll be pushing more tomorrow |
|
Its done. |
|
Really nice refactoring @deepu105 ! (especially the menus and the "route" component that I made) OK concerning the generated code ;) |
This PR contains the Registry upgrade, from Angular 2 to Angular 4.
It contains also some code formatting (#113) and CSS changes.
A part of this work has been based on a generated Gateway, with Angular 4, in v4.2.0.
N.B : Most of changes here concerns the front, so we have to be careful with all next PR, concerning Angular 2 (#98 #99 #112 #114 #116).
N.B.2 : In history.component.html, do not pay attention to the
<template>element for the moment. The Ng-Bootstrap team works on this (ng-bootstrap/ng-bootstrap#1337).All visuals