Fix Yarn test #113
Merged
Fix Yarn test #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepu105
reviewed
Apr 12, 2017
| import { NgbModal } from '@ng-bootstrap/ng-bootstrap'; | ||
| import { JhiHealthCheckComponent } from '../../../../../../main/webapp/app/admin/health/health.component'; | ||
| import { JhiHealthService } from '../../../../../../main/webapp/app/admin/health/health.service'; | ||
| import {async, ComponentFixture, TestBed} from '@angular/core/testing'; |
There was a problem hiding this comment.
should have space after curly brace
There was a problem hiding this comment.
Yes, indeed. I've changed my Intellij TypeScript formatter to respect as possible the actual code format.
Now, I hope it's OK :)
I've just reformat all *.ts and *.css in a new commit
There was a problem hiding this comment.
This file still seems to have wrong formatting
There was a problem hiding this comment.
Rahhh, I've applied the formatting on the webapp package but I've forgot the test/javascript/spec package .... Sorry for that. I will include this change in my next PR.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix add the new RouteService (see #99) to the Health component tests.