Adding vded functionality. Updating gmond templates with host_dmax param #3
Conversation
| validate_string($cluster_url, 'unspecified') | ||
| validate_string($host_dmax, '0') | ||
| validate_string($host_location, 'unspecified') | ||
| validate_string($send_metadata_interval, '300') |
There was a problem hiding this comment.
The validate_string() function checks that all of it's arguments are strings. The additional arguments you've added are static strings so this change doesn't make any sense.
|
I'm happy to see additional configuration options added to this module but I'm concerned about breaking the el5 and el6 packages, which are admittedly dated. I have to admit that I'm not familiar with vded. Is it only exclusively used with ganglia or is it also used stand alone? Does is always need to be installed as the ganglia user? Does it have any package level dependencies on ganglia packages? Where are el5/el6 RPMs available from? As a side note, there are a couple of linter warnings. |
|
@hundredacres Ping? There are comments from my initial code review that haven't been responded to and the PR hasn't been updated. Are you still interested in working on this PR? It's now clear in my mind that VDED should be a stand alone module. |
validation mistakes and updated templates
Conflicts: manifests/gmond.pp manifests/params.pp templates/gmond.conf.el5.erb templates/gmond.conf.el6.erb
|
Removed vded addtion from this module. Going to make a new module for that add-on. |
|
|
|
(Please feel free to ping me if I take more than a few days to respond) |
|
A parameter for |
Added new functionality for VDED.
Added ganglia user/group creation
Updated gmond templates with new params