Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onHttpResponse fails to pick up request headers #6

Closed
ApplySci opened this issue Jun 7, 2019 · 1 comment · Fixed by #7
Closed

onHttpResponse fails to pick up request headers #6

ApplySci opened this issue Jun 7, 2019 · 1 comment · Fixed by #7

Comments

@ApplySci
Copy link
Contributor

ApplySci commented Jun 7, 2019

In this line;

httpRequest.headers.forEach((header, value) {

Shouldn't it be:
response.request.headers.forEach((header, value) {
As httpRequest.headers is empty, having only just been initialised, and response.request is the request as passed into the call.

@ApplySci
Copy link
Contributor Author

ApplySci commented Jun 7, 2019

And similarly, around line 39 of that same file, if body == null && response.request is Request , then httpRequest.body should pick up the value from response.request.body

For clarification, I'm using alice with the http/http package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant