Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Connect with http_interceptor: library #85

Closed
II11II opened this issue Jul 9, 2021 · 3 comments
Closed

[FEATURE] Connect with http_interceptor: library #85

II11II opened this issue Jul 9, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@II11II
Copy link

II11II commented Jul 9, 2021

There is a popular interceptor for http library https://github.com/CodingAleCR/http_interceptor
Please add a feature to intercept requests with http_interceptor library.

P.s. I've seen an example and it violates SOLID principles (No DI for http library)

@II11II II11II added enhancement New feature or request new issue New issue which has not been checked yet labels Jul 9, 2021
@jhomlala
Copy link
Owner

jhomlala commented Jul 9, 2021

@II11II http_interceptor is only an interceptor for Dart's http library which is supported in Alice. Why should I add support for library which simply intercepts requests/responses rather than sending it? Alice provides support for libraries which are http clients.

P.s. I've seen an example and it violates SOLID principles (No DI for http library)
This is example app which shows how to use Alice in the easiest way. There's no purpose of architecting example app with SOLID principles since it's only showcase of features.

@jhomlala jhomlala removed the new issue New issue which has not been checked yet label Jul 9, 2021
@II11II
Copy link
Author

II11II commented Jul 9, 2021

@II11II http_interceptor is only an interceptor for Dart's http library which is supported in Alice. Why should I add support for library which simply intercepts requests/responses rather than sending it? Alice provides support for libraries which are http clients.

P.s. I've seen an example and it violates SOLID principles (No DI for http library)
This is example app which shows how to use Alice in the easiest way. There's no purpose of architecting example app with SOLID principles since it's only showcase of features.

Can you add a method onHttpBaseRequest(BaseRequest request,{dynamic body}) ?
BaseRequest is class in HTTP library.

And give please access to fill your AliceHttpRequest class creating method in the Alice class

@jhomlala
Copy link
Owner

jhomlala commented Nov 7, 2021

@II11II I'm sorry but I don't understand your request. Can you elaborate it?

@II11II II11II closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants