Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desc/builder package should support element comments #85

Closed
jhump opened this issue Nov 8, 2017 · 1 comment
Closed

desc/builder package should support element comments #85

jhump opened this issue Nov 8, 2017 · 1 comment

Comments

@jhump
Copy link
Owner

jhump commented Nov 8, 2017

The builders should both preserve comments as much as possible (when creating a builder from an existing descriptor that has comment info) and provide a mechanism for setting/changing element comments. These comments would be inserted into resulting file descriptors' source_code_info field.

This, combined with protoprint package in #84, would provide a nice model for generating proto source code.
@jhump jhump mentioned this issue Nov 8, 2017
Merged
@jhump
Copy link
Owner Author

jhump commented Nov 8, 2017

Feature addressed in #86

@jhump jhump closed this as completed Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhump