Skip to content

Commit

Permalink
Log dlopen errors in opt builds
Browse files Browse the repository at this point in the history
As the Engine uses `dlopen` to find the `libapp.so`, flutter/flutter#59834 can happen which will prevent `dlopen` from finding the binary. In theory this should be mitigated by flutter#9762, but an internal customer observed errors where `dlopen` is not found. 

The additional logging here can help to rule out that hypothesis. For Googlers, see b/276657840 for more details.
  • Loading branch information
jiahaog committed Apr 25, 2023
1 parent 307416f commit 8422500
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fml/platform/posix/native_library_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ NativeLibrary::NativeLibrary(const char* path) {
::dlerror();
handle_ = ::dlopen(path, RTLD_NOW);
if (handle_ == nullptr) {
FML_DLOG(ERROR) << "Could not open library '" << path << "' due to error '"
FML_LOG(ERROR) << "Could not open library '" << path << "' due to error '"
<< ::dlerror() << "'.";
}
}
Expand Down

0 comments on commit 8422500

Please sign in to comment.