Fall back to a fully qualified path to libapp.so if the library can not be loaded by name #9762

jason-simmons · 2019-07-10T23:12:30Z

libapp.so contains compiled application Dart code. On most Android systems,
this library can be loaded by calling dlopen("libapp.so"), which will search
Android's default library directories.

On some Android devices this does not work as expected. As a workaround, this
patch provides a fallback path to libapp.so based on ApplicationInfo.nativeLibraryDir.

Fixes flutter/flutter#35838

blasten

Thanks for fixing this 👍

…ot be loaded by name libapp.so contains compiled application Dart code. On most Android systems, this library can be loaded by calling dlopen("libapp.so"), which will search Android's default library directories. On some Android devices this does not work as expected. As a workaround, this patch provides a fallback path to libapp.so based on ApplicationInfo.nativeLibraryDir. Fixes flutter/flutter#35838

tvolkert

Didn't fully qualifying it pose problems before when the shared library was still in the zip archive?

jason-simmons · 2019-07-11T00:10:33Z

Yes - loading with dlopen("libapp.so") is preferred because it handles cases like searching within a zip file. This patch tries that first and then falls back to the nativeLibraryDir based path if that doesn't work.

tvolkert · 2019-07-11T00:21:21Z

Does this really fix the case of the bug report then, since isn't libapp.so still compressed in the bug report case?

jason-simmons · 2019-07-11T00:51:08Z

This is intended as a workaround for a specific old Android device where calling dlopen with an unqualified name does not produce the same results as standard Android devices. The affected device is running a variant of Jellybean and predates support for loading libraries directly out of a ZIP file.

tvolkert · 2019-07-11T01:09:07Z

Gotcha. LGTM.

…ry can not be loaded by name (flutter/engine#9762)

flutter/engine@3b94410...bcde838 git log 3b94410..bcde838 --no-merges --oneline bcde838 Roll Wuffs and buildroot (flutter/engine#9791) 3b75979 fix ColorFilter.matrix constness (flutter/engine#9789) 3c9a22c Fall back to a fully qualified path to libapp.so if the library can not be loaded by name (flutter/engine#9762) 298a610 Roll fuchsia/sdk/core/mac-amd64 from XOXaWqvr4OuJ6O3uPefSwSFjZMaEmDHy5JQm3Q8Oc0wC to CDbRdGJ3bu-aWMCZqN5VzfQqIBwDGL2wfFodWABKdCIC (flutter/engine#9790) 833f6b4 Roll src/third_party/skia f9fcf7ffa89a..7825d4983f90 (6 commits) (flutter/engine#9788) 1250c37 Add comments to differentiate two cache paths (flutter/engine#9721) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.

tvolkert · 2019-07-12T17:45:12Z

Can we add a test for this?

jason-simmons · 2019-07-12T17:59:57Z

We could add a device with this issue to the device lab. For unit tests, there's an ongoing discussion about how to test Java embedding code that relies on Android APIs.

blasten · 2019-07-12T18:22:09Z

I just checked the Firebase device farm and the lowest Android version they have is 4.3.x. Maybe that version still reproduces the issue.

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see flutter#9762)

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see #9762)

…ot be loaded by name (flutter#9762) libapp.so contains compiled application Dart code. On most Android systems, this library can be loaded by calling dlopen("libapp.so"), which will search Android's default library directories. On some Android devices this does not work as expected. As a workaround, this patch provides a fallback path to libapp.so based on ApplicationInfo.nativeLibraryDir. Fixes flutter/flutter#35838

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see flutter#9762)

…ot be loaded by name (#9762) libapp.so contains compiled application Dart code. On most Android systems, this library can be loaded by calling dlopen("libapp.so"), which will search Android's default library directories. On some Android devices this does not work as expected. As a workaround, this patch provides a fallback path to libapp.so based on ApplicationInfo.nativeLibraryDir. Fixes flutter/flutter#35838

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see #9762)

flutter/engine#9762 flutter/engine#9890 flutter/engine#9903

kf6gpe · 2019-07-22T20:15:06Z

This PR has been merged into a hotfix candidate, 1.7.8+hotfix.4, currently in the beta channel. If it soaks well, we anticipate pushing this to stable soon.

angel1st · 2019-07-23T10:24:53Z

Thanks, @kf6gpe - I can confirm 1.7.8+hotfix.4 works pretty well and in fact it also does not have the crash currently introduced into master channel.

flutter/engine@3b94410...bcde838 git log 3b94410..bcde838 --no-merges --oneline bcde838 Roll Wuffs and buildroot (flutter/engine#9791) 3b75979 fix ColorFilter.matrix constness (flutter/engine#9789) 3c9a22c Fall back to a fully qualified path to libapp.so if the library can not be loaded by name (flutter/engine#9762) 298a610 Roll fuchsia/sdk/core/mac-amd64 from XOXaWqvr4OuJ6O3uPefSwSFjZMaEmDHy5JQm3Q8Oc0wC to CDbRdGJ3bu-aWMCZqN5VzfQqIBwDGL2wfFodWABKdCIC (flutter/engine#9790) 833f6b4 Roll src/third_party/skia f9fcf7ffa89a..7825d4983f90 (6 commits) (flutter/engine#9788) 1250c37 Add comments to differentiate two cache paths (flutter/engine#9721) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.

flutter/engine#9762 flutter/engine#9890 flutter/engine#9903

As the Engine uses `dlopen` to find the `libapp.so`, flutter/flutter#59834 can happen which will prevent `dlopen` from finding the binary. In theory this should be mitigated by flutter#9762, but an internal customer observed errors where `dlopen` is not found. The additional logging here can help to rule out that hypothesis. For Googlers, see b/276657840 for more details.

As the Engine uses `dlopen` to find the `libapp.so`, flutter/flutter#59834 can happen which will prevent `dlopen` from finding the binary. In theory this should be mitigated by #9762, but an internal customer observed errors that could be related. The additional logging here can help to rule out that hypothesis. For Googlers, see b/276657840 for more details. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

googlebot added the cla: yes label Jul 10, 2019

jason-simmons requested review from tvolkert, chinmaygarde and blasten July 10, 2019 23:12

blasten approved these changes Jul 10, 2019

View reviewed changes

jason-simmons force-pushed the bug_35838 branch from 7341212 to 76461a5 Compare July 10, 2019 23:30

tvolkert reviewed Jul 10, 2019

View reviewed changes

tvolkert approved these changes Jul 11, 2019

View reviewed changes

chinmaygarde approved these changes Jul 11, 2019

View reviewed changes

jason-simmons merged commit 3c9a22c into flutter:master Jul 11, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2019

3c9a22c Fall back to a fully qualified path to libapp.so if the libra…

5c79203

…ry can not be loaded by name (flutter/engine#9762)

This was referenced Jul 11, 2019

Roll engine 3b944102a56e..3c9a22c778f8 (4 commits) flutter/flutter#36011

Closed

Roll engine 3b944102a56e..bcde838d778e (6 commits) flutter/flutter#36020

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2019

3c9a22c Fall back to a fully qualified path to libapp.so if the libra…

4d7b91e

…ry can not be loaded by name (flutter/engine#9762)

jason-simmons added a commit to jason-simmons/flutter_engine that referenced this pull request Jul 17, 2019

Log dlopen errors only in debug mode

7b77ef7

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see flutter#9762)

jason-simmons mentioned this pull request Jul 17, 2019

Log dlopen errors only in debug mode #9890

Merged

jason-simmons added a commit that referenced this pull request Jul 17, 2019

Log dlopen errors only in debug mode (#9890)

5d9f7b1

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see #9762)

tvolkert mentioned this pull request Jul 17, 2019

libapp.so not found on Android 4.1.2 flutter/flutter#35838

Closed

tvolkert pushed a commit to tvolkert/engine that referenced this pull request Jul 17, 2019

Log dlopen errors only in debug mode (flutter#9890)

3498ad4

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see flutter#9762)

tvolkert pushed a commit that referenced this pull request Jul 17, 2019

Log dlopen errors only in debug mode (#9890)

badb7bf

dlopen errors are expected behavior when locating libapp.so on some older Android devices (see #9762)

tvolkert added a commit to tvolkert/flutter that referenced this pull request Jul 18, 2019

Bump engine version

41fe9a0

flutter/engine#9762 flutter/engine#9890 flutter/engine#9903

tvolkert mentioned this pull request Jul 18, 2019

Bump engine version flutter/flutter#36428

Merged

tvolkert added a commit to flutter/flutter that referenced this pull request Jul 18, 2019

Bump engine version (#36428)

0d4d598

flutter/engine#9762 flutter/engine#9890 flutter/engine#9903

tvolkert mentioned this pull request Jul 20, 2019

Dart VM crash within the TypeCheck runtime entry point flutter/flutter#36398

Closed

KevinG2011 pushed a commit to pepper-ios/flutter that referenced this pull request Apr 23, 2020

Bump engine version (flutter#36428)

20952b9

flutter/engine#9762 flutter/engine#9890 flutter/engine#9903

chinmaygarde mentioned this pull request Jun 8, 2020

Native Error: Couldn't load flutter from loader dalvik.system.PathClassLoader / couldn't find "libflutter.so" flutter/flutter#37566

Closed

This was referenced Apr 25, 2023

Log dlopen errors in opt builds jiahaog/flutter-engine#33

Closed

Log dlopen errors in opt builds #41477

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fall back to a fully qualified path to libapp.so if the library can not be loaded by name #9762

Fall back to a fully qualified path to libapp.so if the library can not be loaded by name #9762

jason-simmons commented Jul 10, 2019

blasten left a comment

tvolkert left a comment

jason-simmons commented Jul 11, 2019

tvolkert commented Jul 11, 2019

jason-simmons commented Jul 11, 2019

tvolkert commented Jul 11, 2019

tvolkert commented Jul 12, 2019

jason-simmons commented Jul 12, 2019

blasten commented Jul 12, 2019

kf6gpe commented Jul 22, 2019

angel1st commented Jul 23, 2019

Fall back to a fully qualified path to libapp.so if the library can not be loaded by name #9762

Fall back to a fully qualified path to libapp.so if the library can not be loaded by name #9762

Conversation

jason-simmons commented Jul 10, 2019

blasten left a comment

Choose a reason for hiding this comment

tvolkert left a comment

Choose a reason for hiding this comment

jason-simmons commented Jul 11, 2019

tvolkert commented Jul 11, 2019

jason-simmons commented Jul 11, 2019

tvolkert commented Jul 11, 2019

tvolkert commented Jul 12, 2019

jason-simmons commented Jul 12, 2019

blasten commented Jul 12, 2019

kf6gpe commented Jul 22, 2019

angel1st commented Jul 23, 2019