Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on additive aggregation weight initialization #8

Closed
seungwonpark opened this issue Apr 11, 2019 · 2 comments
Closed

Question on additive aggregation weight initialization #8

seungwonpark opened this issue Apr 11, 2019 · 2 comments

Comments

@seungwonpark
Copy link

Hi, I have a question about weight initialization of node's additive aggregation here.

At model.py#L41, weights are initialized with torch.ones, not torch.zeros. This will make actual weights to be initialized with 0.7311, not 0.5000. Was it intended? (Though it won't affect much on training, I'm just curious about it.)

@JiaminRen
Copy link
Owner

I don't think it matters. A single parameter should be easy to optimize.

@seungwonpark
Copy link
Author

Thanks for the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants