Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and adding of various crest URL #46

Open
JianLoong opened this issue Oct 10, 2022 · 0 comments
Open

Updating and adding of various crest URL #46

JianLoong opened this issue Oct 10, 2022 · 0 comments

Comments

@JianLoong
Copy link
Owner

This issue is related to #44

The flag URL has been fixed however, the "crest_url" which points to the Wikipedia website entry has not been addressed.

For example in the file state/v1/johor.json the

"crest_url" information is currenty

"https://en.wikipedia.org/wiki/Johor#/media/File:Coat_of_arms_of_Johor.svg"

when it should be instead

"https://upload.wikimedia.org/wikipedia/commons/thumb/6/60/Coat_of_arms_of_Johor.svg/1280px-Coat_of_arms_of_Johor.svg.png"

This is the same as several other entries.

Missing crest_url from other states should also be added to handle this issue.

@rafik7704 rafik7704 mentioned this issue Apr 5, 2023
@JianLoong JianLoong removed help wanted Extra attention is needed good first issue Good for newcomers labels Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant