This repository has been archived by the owner on Nov 5, 2018. It is now read-only.
email templating update #1043
Merged
email templating update #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lads,
During the process to update to the most recent version - beside my other issue with the reports - I found this limitation in the new email templating:
I'm running Jigoshop on a networked WP install and while I can completely replace the
layout.htmlin my theme I can't distinguish between my different sites to do slightly different things (basically putting in site-specific URLs) for the heading.For the footer there's a hook I can use, but I would need a similar one for the heading block.
More to that: since I'm about to put non-basic stuff in the heading, the same string won't be good for having it in the HTML title. So I also suggest to separate the two while providing the same content by default.
What do you think?