Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mal_id for 'staff' on club endpoint always return 0 #279

Closed
seanbreckenridge opened this issue Apr 11, 2020 · 1 comment
Closed

mal_id for 'staff' on club endpoint always return 0 #279

seanbreckenridge opened this issue Apr 11, 2020 · 1 comment

Comments

@seanbreckenridge
Copy link
Contributor

seanbreckenridge commented Apr 11, 2020

Reported by Ganen on the discord:

https://api.jikan.moe/v3/club/72940

https://github.com/jikan-me/jikan/blob/master/src/Model/Club/Club.php#L179-L185
https://github.com/jikan-me/jikan/blob/master/src/Parser/Club/ClubParser.php#L255-L291 never parses a MAL ID
I think this is because in Club.php its defined as a MalUrl[], instead of Model specific to a club user:
https://github.com/jikan-me/jikan/blob/master/src/Model/Common/MalUrl.php
and https://github.com/jikan-me/jikan/tree/master/src/Parser/Common/MalUrlParser.php
which that defaults to 0

<div class="borderClass"><a href="/profile/daya">daya</a> (Admin)</div>

no way to parse the user id for someone from the information on the club page
so, I think some new model specific to a club user should probably be changed to remove the mal_id field in v4

@irfan-dahir
Copy link
Collaborator

Fixed in REST v4 and referenced commit above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants