Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string_boundary_linter() could recognize double-anchored regexes as being == #1613

Closed
MichaelChirico opened this issue Oct 4, 2022 · 0 comments · Fixed by #2372
Closed

string_boundary_linter() could recognize double-anchored regexes as being == #1613

MichaelChirico opened this issue Oct 4, 2022 · 0 comments · Fixed by #2372
Labels
lint-metadata

Comments

@MichaelChirico
Copy link
Collaborator

Replacement for #1166.

grepl("^a_fixed_string$", x) is the same as x == "a_fixed_string", rather than being replaced with startsWith() or endsWith(), == is a better replacement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lint-metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recognize full-string "boundary checks" in string_boundary_linter() r-lib/lintr
1 participant
@MichaelChirico