Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching across libraries feature missing #262

Closed
quissicks opened this issue Oct 26, 2020 · 6 comments
Closed

Searching across libraries feature missing #262

quissicks opened this issue Oct 26, 2020 · 6 comments
Labels
🐛bug Something isn't working
Milestone

Comments

@quissicks
Copy link

Thanks to Ger for providing a new update and keeping qiqqa alive. I have just downloaded the new version and noticed that the search across libraries function availalble in the commercial verison is missing.

@GerHobbelt GerHobbelt added the 🐛bug Something isn't working label Oct 26, 2020
@GerHobbelt
Copy link
Collaborator

GerHobbelt commented Oct 26, 2020

😓 Never noticed that one on the commercial version -- didn't have a use for it then. Must have been removed when Qiqqa got open sourced or I effed up somewhere 🤔

@quissicks
Copy link
Author

quissicks commented Oct 26, 2020 via email

@GerHobbelt
Copy link
Collaborator

Note to self for later, while I'm hunting some stuff for #257:
for this issue, I should into the code flow into & out of class CrossLibrarySearchControl.

@GerHobbelt
Copy link
Collaborator

@quissicks : Qiqqa already has 'search across libraries' AFAICT.

Here's how it should appear and be used:

When You start Qiqqa, when the HOME tab is active, the search box in top-right corner will search across all libraries:

image

Here is an example of Qiqqa doing so, searching for the word 'panasonic' across several test libraries of mine (you MAY therefor see apparently duplicate results in the search results list: this can happen when a document is stored in multiple libraries):

image

Also note that the same search box, but now with one of the libraries OPEN and ACTIVE (tab), will only search said library:

NOTE

You can check the greyed hint text in the search box, when it is empty, as well: that will tell you whether it will search in a single (active) library or in all libraries: this can also be observed in the screenshots.

image

Hope that helps!

😅
(Had forgotten about the functionality myself; only while I was working on another issue did I observe this and a quick test and code review revealed that search-across-all-libraries is already present and working in Qiqqa.)

@GerHobbelt GerHobbelt added this to the v82 milestone Oct 30, 2020
@GerHobbelt
Copy link
Collaborator

@quissicks : please let me know in reply to this issue if the 'search across libraries' feature works as described above (see #262 (comment)) or whether we're talking about different things.

When it works, I'll be able to close this issue 😄

@GerHobbelt
Copy link
Collaborator

Closed as resolved after private comms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants