Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~ is not included #7

Open
wanghenshui opened this issue Dec 21, 2019 · 3 comments · May be fixed by #8
Open

~ is not included #7

wanghenshui opened this issue Dec 21, 2019 · 3 comments · May be fixed by #8
Labels
duplicate This issue or pull request already exists

Comments

@wanghenshui
Copy link

wanghenshui commented Dec 21, 2019

thanks for you project! tiny and embedable!

if (line[i] != '\t' && (line[i] < 32 || line[i] > 125))

line[i] > 126

@jimmiebergmann jimmiebergmann added the duplicate This issue or pull request already exists label Jan 3, 2020
@wanghenshui wanghenshui linked a pull request Jan 7, 2020 that will close this issue
@hanzheteng
Copy link

Just to say that I have encountered the same issue today, where ~ is needed as part of a pathname in Linux. This feature is important. Thanks.

@vtushevskiy
Copy link

Now any field containing any tilde (like home filesystem path "~/Downloads") is causing exception

@leobackes
Copy link

This validation, actually, breaks utf8 support.
For my current use, I just commented this whole block, and it doesn't seem to have any noticeable bad effect.

I'm new to Yaml, so, I don't know what would be an invalid character in this context, but maybe those should be specified, instead of checking a narrow range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants