Update EventEmitter import for es module compatibility #1295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
Changed the
packages/core/src/index.js
import of theEventEmitter
class.Was:
import EventEmitter from "events"
Now:
import * as EventEmitter from "events"
This change was required for building a project utilizing Jimp custom to build a slimmer version of the library. The project is built as a module with target
esnext
on Node20 and Typescript using Vite.Without this fix,
vite build
will produce the following error:The
events
package is not an es module yet, see Issue 86 and converting it to one is not on the roadmap as far as I can tell. Therefore, this fix should be applied to Jimp directly.What else might be affected
Compatibility may be affected when building Jimp not as an es module.
Tasks