fix: fix override of empty docs (#4350)

jina/orchestrate/flow/base.py

@@ -1221,7 +1221,6 @@ def client(self) -> 'BaseClient':
             host=self.host,
             port=self.port_expose,
             protocol=self.protocol,
-            results_as_docarray=True,
         )
         kwargs.update(self._common_kwargs)
         return Client(**kwargs)

jina/types/request/data.py

@@ -46,7 +46,7 @@ def docs(self, value: DocumentArray):
 
             :param value: a DocumentArray
             """
-            if value:
+            if value is not None:
                 self._loaded_doc_array = None
                 self._content.docs.CopyFrom(value.to_protobuf())
 

tests/unit/serve/runtimes/request_handlers/test_data_request_handlers.py

@@ -37,6 +37,12 @@ def foo(self, docs, **kwargs):
         return docs
 
 
+class ClearDocsExecutor(Executor):
+    @requests
+    def foo(self, docs, **kwargs):
+        docs.clear()
+
+
 @pytest.fixture()
 def logger():
     return JinaLogger('data request handler')
@@ -112,3 +118,19 @@ async def test_data_request_handler_change_docs_from_partial_requests(logger):
     assert len(response.docs) == 10 * NUM_PARTIAL_REQUESTS
     for doc in response.docs:
         assert doc.text == 'changed document'
+
+
+@pytest.mark.asyncio
+async def test_data_request_handler_clear_docs(logger):
+    args = set_pod_parser().parse_args(['--uses', 'ClearDocsExecutor'])
+    handler = DataRequestHandler(args, logger)
+
+    req = list(
+        request_generator(
+            '/', DocumentArray([Document(text='input document') for _ in range(10)])
+        )
+    )[0]
+    assert len(req.docs) == 10
+    response = await handler.handle(requests=[req])
+
+    assert len(response.docs) == 0