Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix override of empty docs #4350

Merged
merged 2 commits into from
Feb 16, 2022
Merged

fix: fix override of empty docs #4350

merged 2 commits into from
Feb 16, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 16, 2022

No description provided.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/type labels Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #4350 (1853b15) into master (c07f3c1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4350      +/-   ##
==========================================
+ Coverage   87.61%   87.71%   +0.09%     
==========================================
  Files         114      114              
  Lines        8325     8325              
==========================================
+ Hits         7294     7302       +8     
+ Misses       1031     1023       -8     
Flag Coverage Δ
daemon 42.07% <0.00%> (+0.01%) ⬆️
jina 87.45% <100.00%> (+2.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/flow/base.py 91.00% <ø> (+5.16%) ⬆️
jina/types/request/data.py 97.93% <100.00%> (ø)
jina/serve/networking.py 71.27% <0.00%> (-12.47%) ⬇️
jina/orchestrate/pods/jinad.py 93.02% <0.00%> (-0.78%) ⬇️
jina/jaml/__init__.py 94.29% <0.00%> (+0.38%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 100.00% <0.00%> (+0.56%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.61%) ⬆️
jina/orchestrate/pods/__init__.py 90.00% <0.00%> (+0.62%) ⬆️
jina/helper.py 81.90% <0.00%> (+0.83%) ⬆️
jina/serve/runtimes/gateway/http/app.py 90.80% <0.00%> (+1.14%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dcb50a...1853b15. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 16, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1249, delta to last 2 avg.: -10%
  • 🐎🐎🐎🐎 query QPS at 55, delta to last 2 avg.: +27%
  • 🐎🐎🐎🐎 avg flow time within 1.4916 seconds, delta to last 2 avg.: +20%
  • 🐎🐎 import jina within 0.3553 seconds, delta to last 2 avg.: +7%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1249 55 1.4916 0.3553
2.7.0 1212 55 1.1939 0.314
2.6.4 1578 30 1.2795 0.3484

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM requested review from jacobowitz and removed request for jacobowitz February 16, 2022 07:48
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Feb 16, 2022
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was running the image test case and it seems to fix the issue as far as I can see

@JoanFM JoanFM merged commit 3420f5e into master Feb 16, 2022
@JoanFM JoanFM deleted the fix-http-slow branch February 16, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants