refactor(driver): refactor reduce driver

jina-ai · Jul 17, 2020 · b23ed07 · b23ed07
1 parent 66c8e75
commit b23ed07
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/jina/drivers/rank.py b/jina/drivers/rank.py
@@ -10,6 +10,7 @@
 if False:
     from ..proto import jina_pb2
 
+
 class BaseRankDriver(BaseExecutableDriver):
     """Drivers inherited from this Driver will bind :meth:`craft` by default """
 

diff --git a/jina/drivers/reduce.py b/jina/drivers/reduce.py
@@ -7,7 +7,7 @@
 from . import BaseRecursiveDriver
 from ..excepts import NoExplicitMessage
 from ..proto import jina_pb2
-
+from copy import copy
 
 class ReduceDriver(BaseRecursiveDriver):
 
@@ -71,7 +71,7 @@ def reduce(self, *args, **kwargs):
 
     def apply(self, doc: 'jina_pb2.Document', *args, **kwargs):
         if doc.id not in self.doc_pointers:
-            self.doc_pointers[doc.id] = doc  # what? why is this deep copy?
+            self.doc_pointers[doc.id] = copy(doc)  # force a shallow copy
         else:
             self.doc_pointers[doc.id].chunks.extend(doc.chunks)
             self.doc_pointers[doc.id].matches.extend(doc.matches)