Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem updating faiss-search-example (General problems with indexers , ref_indexer and ContainerPea) #1438

Closed
JoanFM opened this issue Dec 11, 2020 · 3 comments · Fixed by #1596
Labels
priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. type/bug Something isn't working

Comments

@JoanFM
Copy link
Member

JoanFM commented Dec 11, 2020

Describe the bug
I have been trying to update faiss-search-example (jina-ai/examples#318) and I am struggling to get it right.

So the problem is related to workspace ref_indexers and ContainerPea

Let me try to explain in detail:

  • At index time NumpyIndexer is working with index_workspace as workspace, there it serializes itself to indexer_workspace/wrapidx.bin

  • At query time, the docker image is started mapping volume indexer_workspace (but the problem is that inside docker this path is not proper with respect to workspace inside the docker image (from where jina pod entrypoint is run). Then there is a missmatch of the workspace stored in wrapidx.bin and the one that FaissIndexer should work on.

  • At query time NumpyIndexer is passed as ref_indexer to the FaissIndexer, and the index_abspath is extracted from the ref_indexer which is not considering where the volume is mapped.

As my experience, this problem has 2 sides of the story:

  • We should think of providing more freedom to the user on what folder is mapping and where it will be mapped inside the container.

  • Have more clarity in from where the ContainerPea is working (absolute, relative, etc...)

  • Is the fact that we are using workspace as our base for hub image could conflict with the workspace with indexer files?

EXTRA PROPOSAL:
Create an extra examples test for faiss-search-example

@JoanFM JoanFM added the type/bug Something isn't working label Dec 11, 2020
@JoanFM JoanFM changed the title Problem updating faiss-search-example Problem updating faiss-search-example (General problems with indexers , ref_indexer and ContainerPea Dec 11, 2020
@JoanFM JoanFM changed the title Problem updating faiss-search-example (General problems with indexers , ref_indexer and ContainerPea Problem updating faiss-search-example (General problems with indexers , ref_indexer and ContainerPea) Dec 11, 2020
@JoanFM JoanFM added the priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. label Dec 11, 2020
@jina-bot
Copy link
Member

jina-bot commented Jan 1, 2021

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days

@JoanFM
Copy link
Member Author

JoanFM commented Jan 5, 2021

Reopening issue. Will do a double check and update example te confirm

@JoanFM JoanFM reopened this Jan 5, 2021
@nan-wang nan-wang removed the Stale label Jan 6, 2021
@JoanFM
Copy link
Member Author

JoanFM commented Jan 7, 2021

Closed by #1596

Example rewritten in jina-ai/examples#318

@JoanFM JoanFM closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants