Problem updating faiss-search-example
(General problems with indexers
, ref_indexer
and ContainerPea
)
#1438
Labels
priority/critical
Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.
type/bug
Something isn't working
Describe the bug
I have been trying to update
faiss-search-example
(jina-ai/examples#318) and I am struggling to get it right.So the problem is related to
workspace
ref_indexers
andContainerPea
Let me try to explain in detail:
At index time
NumpyIndexer
is working withindex_workspace
as workspace, there it serializes itself toindexer_workspace/wrapidx.bin
At query time, the docker image is started mapping volume
indexer_workspace
(but the problem is that insidedocker
this path is not proper with respect toworkspace
inside the docker image (from wherejina pod
entrypoint is run). Then there is a missmatch of theworkspace
stored inwrapidx.bin
and the one thatFaissIndexer
should work on.At query time
NumpyIndexer
is passed asref_indexer
to theFaissIndexer
, and theindex_abspath
is extracted from theref_indexer
which is not considering where the volume is mapped.As my experience, this problem has 2 sides of the story:
We should think of providing more freedom to the user on what folder is mapping and where it will be mapped inside the container.
Have more clarity in from where the
ContainerPea
is working (absolute, relative, etc...)Is the fact that we are using
workspace
as our base for hub image could conflict with theworkspace
with indexer files?EXTRA PROPOSAL:
Create an extra examples test for
faiss-search-example
The text was updated successfully, but these errors were encountered: