Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: volumes can be mapped to arbitrary path in container #1596

Merged
merged 3 commits into from Jan 5, 2021
Merged

feat: volumes can be mapped to arbitrary path in container #1596

merged 3 commits into from Jan 5, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 5, 2021

Changes introduced
Iteration to fix #1438

It allows to have volumes mapped to arbitrary path in the container. This combined with #1595 can allow using ref_indexer inside Docker

@JoanFM JoanFM requested a review from a team as a code owner January 5, 2021 16:33
@JoanFM JoanFM requested review from yuanbit and FionnD January 5, 2021 16:33
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Jan 5, 2021
@jina-bot jina-bot added the area/testing This issue/PR affects testing label Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2021 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1810, delta to last 3 avg.: +3%
  • 😶 query QPS at 30, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1810 30
0.9.1 1755 30
0.8.22 1728 29
0.8.21 1756 29

Backed by latency-tracking. Further commits will update this comment.

@JoanFM
Copy link
Member Author

JoanFM commented Jan 5, 2021

@hanxiao could you fix the commit-lint error, it is a common trap when commiting suggestions

@JoanFM
Copy link
Member Author

JoanFM commented Jan 5, 2021 •
edited

@hanxiao could you fix the commit-lint error, it is a common trap when commiting suggestions

Fixed this, no prob

@hanxiao hanxiao merged commit 63bc924 into master Jan 5, 2021
@hanxiao hanxiao deleted the feat-volumes-map branch January 5, 2021 19:20
@JoanFM JoanFM mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@yuanbit yuanbit Awaiting requested review from yuanbit

@FionnD FionnD Awaiting requested review from FionnD

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem updating faiss-search-example (General problems with indexers , ref_indexer and ContainerPea)
3 participants
@JoanFM @hanxiao @jina-bot