Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ref indexer avoid getting abspath #1595

Merged
merged 1 commit into from Jan 5, 2021
Merged

feat: ref indexer avoid getting abspath #1595

merged 1 commit into from Jan 5, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 5, 2021 •
edited

Changes introduced
Avoid inheriting from ref_indexer the index_abspath to avoid the inflexibility of moving workspaces into containers

One of the iterations in the direction of fixing #1438

@JoanFM JoanFM requested a review from a team as a code owner January 5, 2021 15:49
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/indexer labels Jan 5, 2021
@JoanFM JoanFM marked this pull request as draft January 5, 2021 15:51
@github-actions
Copy link

github-actions bot commented Jan 5, 2021 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1980, delta to last 3 avg.: +0%
  • 😶 query QPS at 36, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1980 36
0.9.1 1928 36
0.8.22 2022 37
0.8.21 2042 37

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM mentioned this pull request Jan 5, 2021
Merged
@JoanFM JoanFM marked this pull request as ready for review January 5, 2021 16:41
@hanxiao hanxiao merged commit 692c2d9 into master Jan 5, 2021
@hanxiao hanxiao deleted the fix-ref-indexer branch January 5, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@Roshanjossey Roshanjossey Awaiting requested review from Roshanjossey

@aga11313 aga11313 Awaiting requested review from aga11313

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/indexer size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoanFM @hanxiao @jina-bot