Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use multiple gRPC channels using connection pool #5466

Closed
girishc13 opened this issue Nov 30, 2022 · 5 comments
Closed

feat: use multiple gRPC channels using connection pool #5466

girishc13 opened this issue Nov 30, 2022 · 5 comments
Labels

Comments

@girishc13
Copy link
Contributor

Describe the feature

Using a single channel for all gRPC requests can become a performance bottleneck and a single point of failure in the cloud environment. Network issues are the most common root cause in the cloud. Using multiple connections will reduce the impact if one connection is facing issues. Recreating connections periodically will help to avoid intermittent network issues.

References:

Your proposal

A potential implementation might be available in the google-cloud-python library. A custom solution is required since gRPC Python doesn't have the support yet.


Environment

Screenshots

@girishc13
Copy link
Contributor Author

girishc13 commented Jan 19, 2023

Give the limitation in the Python library, I'm not sure if this feature can be implemented.
grpc/grpc#20985 (comment)

@JoanFM
Copy link
Member

JoanFM commented Jan 19, 2023

Should we go all the way and migrate to golang?

@JoanFM
Copy link
Member

JoanFM commented Jan 19, 2023

wrap the golang client in Python?

@girishc13
Copy link
Contributor Author

I'm not sure about the packing and version conflicts. This would make it harder for the user to depend on something other than python. Let's think about improving the client-go library and verify if there are major improvements. If not then let's stick with the plain python library.

@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants