Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: silence or minimize output of jina ping command #5474

Closed
girishc13 opened this issue Dec 1, 2022 · 0 comments · Fixed by #5476
Closed

feat: silence or minimize output of jina ping command #5474

girishc13 opened this issue Dec 1, 2022 · 0 comments · Fixed by #5476

Comments

@girishc13
Copy link
Contributor

girishc13 commented Dec 1, 2022

Describe the feature

The jina ping command is also used for the startup, readinesss and/or liveness probe. The command currently by default prints the jina logo and the arguments of the command which pollutes the kubernetes events logger and the pod events.

Events:
  Type     Reason     Age   From               Message
  ----     ------     ----  ----               -------
  Normal   Scheduled  16m   default-scheduler  Successfully assigned test-failure-scenarios/executor0-57788fb8fc-tjzbm to pytest-kind-control-plane
  Normal   Pulled     16m   kubelet            Container image "cr.l5d.io/linkerd/proxy-init:v1.5.3" already present on machine
  Normal   Created    16m   kubelet            Created container linkerd-init
  Normal   Started    16m   kubelet            Started container linkerd-init
  Normal   Pulled     16m   kubelet            Container image "cr.l5d.io/linkerd/proxy:stable-2.11.4" already present on machine
  Normal   Created    16m   kubelet            Created container linkerd-proxy
  Normal   Started    16m   kubelet            Started container linkerd-proxy
  Warning  Unhealthy  15m   kubelet            Liveness probe failed: executing liveness probe...

MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWWWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMWNNNNNNNWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMNNNNNNNNNMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMWNNNNNNNNMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMWNNNWWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMWxxxxxxxxxOMMMMMNxxxxxxxxx0MMMMMKddddddxkKWMMMMMMMMMMMMXOxdddxONMMMM
MMMMMMMMMMMMXllllllllldMMMMM0lllllllllxMMMMMOllllllllllo0MMMMMMMM0olllllllllo0MM
MMMMMMMMMMMMXllllllllldMMMMM0lllllllllxMMMMMOlllllllllllloWMMMMMdllllllllllllldM
MMMMMMMMMMMMXllllllllldMMMMM0lllllllllxMMMMMOllllllllllllloMMMM0lllllllllllllllK
MMMMMMMMMMMMKllllllllldMMMMM0lllllllllxMMMMMOllllllllllllllKMMM0lllllllllllllllO
MMMMMMMMMMMMKllllllllldMMMMM0lllllllllxMMMMMOllllllllllllll0MMMMollllllllllllllO
MWOkkkkk0MMMKlllllllllkMMMMM0lllllllllxMMMMMOllllllllllllll0MMMMMxlllllllllllllO
NkkkkkkkkkMMKlllllllloMMMMMM0lllllllllxMMMMMOllllllllllllll0MMMMMMWOdolllllllllO
KkkkkkkkkkNMKllllllldMMMMMMMMWWWWWWWWWMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MOkkkkkkk0MMKllllldXMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMWX00KXMMMMXxk0XMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM


/usr/local/bin/jina ping executor           
127.0.0.1:8080                              
╭─────────────────────────┬────────────────╮
│                Argument │ Value          │
├─────────────────────────┼────────────────┤
│                attempts │ 1              │
│                     cli │ ping           │
│                    host │ 127.0.0.1:8080 │
│ min-successful-attempts │ 1              │
│                  target │ executor       │
│                 timeout │ 3000           │
╰─────────────────────────┴────────────────╯
INFO   executor0@47 ping executor on 127.0.0.1:8080 at 0     [12/01/22 12:58:50]
       round...                                                                 
INFO   executor0@47 ping executor on 127.0.0.1:8080 at 0                        
       round takes 0 seconds (0.01s)                                            
INFO   executor0@47 avg. latency: 5 ms                       [12/01/22 12:58:51]
INFO   executor0@47 readiness check succeeded 1 times!!!

Your proposal

Remove the jina logo and args printing. Move the log messages to debug level.

Environment

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant