Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatic testing/building of hub images on new release #1298

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

cristianmtr
Copy link
Contributor

@cristianmtr cristianmtr commented Nov 17, 2020

v2

  • don't bump Jina version, as it's not used by the builder
  • bump dummy field of timestamp
  • check if combination of module version + jina version have been tested before (by looking up PR name)
  • only open Draft PRs
  • only open issues if the checks fail
  • close PRs

v1

  • traverse list of modules
  • remove those that have opened issues
  • try to open PR to bump version and add new jina version
  • wait for PR checks to finish
  • if they fail, open issue in hub
  • allow for more configuration of workflow (for future separation into its own Marketplace action)

This will be submitted as-is, and the work for the GitHub Action hub builder will be another PR.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #1298 (eeb83a1) into master (895112e) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
- Coverage   83.37%   83.31%   -0.06%     
==========================================
  Files         101      101              
  Lines        6705     6706       +1     
==========================================
- Hits         5590     5587       -3     
- Misses       1115     1119       +4     
Impacted Files Coverage Δ
jina/peapods/container.py 88.40% <100.00%> (-2.78%) ⬇️
jina/drivers/querylang/select.py 79.31% <0.00%> (-6.90%) ⬇️
jina/peapods/grpc_asyncio.py 75.51% <0.00%> (-1.03%) ⬇️
jina/docker/hubio.py 70.40% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895112e...b60b76a. Read the comment docs.

scripts/jina-hub-update.py Outdated Show resolved Hide resolved
@cristianmtr cristianmtr force-pushed the ci-hub-automatic-approve-merge branch 16 times, most recently from fb78ea5 to 4e54808 Compare November 19, 2020 08:09
@jina-bot jina-bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Nov 19, 2020
@cristianmtr cristianmtr force-pushed the ci-hub-automatic-approve-merge branch 9 times, most recently from 422717b to 6c6f381 Compare November 19, 2020 12:21
@cristianmtr cristianmtr requested a review from a team as a code owner November 20, 2020 08:32
scripts/jina-hub-update.py Outdated Show resolved Hide resolved
scripts/jina-hub-update.py Outdated Show resolved Hide resolved
scripts/jina-hub-update.py Outdated Show resolved Hide resolved
scripts/jina-hub-update.py Outdated Show resolved Hide resolved
@cristianmtr cristianmtr marked this pull request as draft November 23, 2020 09:15
@cristianmtr cristianmtr force-pushed the ci-hub-automatic-approve-merge branch 8 times, most recently from da93220 to d1fdcd2 Compare November 23, 2020 15:13
@cristianmtr cristianmtr changed the title ci: auto approve/merge chore tasks for hub ci: automatic testing/building of hub images on new release Nov 23, 2020
@cristianmtr cristianmtr marked this pull request as ready for review November 23, 2020 15:39
README.md Outdated Show resolved Hide resolved
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest, LGTM!

@hanxiao hanxiao merged commit dfacc51 into master Nov 24, 2020
@hanxiao hanxiao deleted the ci-hub-automatic-approve-merge branch November 24, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants