tests(integration): improve test_hello_world #1305
Conversation
|
Bad commit message. Instead of |
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
==========================================
+ Coverage 83.14% 83.84% +0.69%
==========================================
Files 95 101 +6
Lines 6544 6733 +189
==========================================
+ Hits 5441 5645 +204
+ Misses 1103 1088 -15
Continue to review full report at Codecov.
|
bio-howard
force-pushed
the
fix-test-helloworld-1304
branch
from
b66cdca
to
7af663a
Compare
|
@nan-wang as it's described here: #1304 I think that test test_helloworld(tmpdir) doesn't "really" test if we are calling hello-world. The result tells if jina hello-world was called and any option which accepts --workdir parameter was executed properly. It makes a risk that other script will be executed, it won't be hello-world and it will still pass the test. Test which is added by me stops after it will recognize that hello world script was being executed. It's not a big time cost. |
tests/integration/test_helloworld.py
Outdated
| @@ -13,10 +13,29 @@ | |||
|
|
|||
|
|
|||
| @pytest.mark.timeout(360) | |||
| def test_helloworld(tmpdir): | |||
| def test_helloworld_call(tmpdir): | |||
There was a problem hiding this comment.
But then why keep this one as well?
There was a problem hiding this comment.
I thought that it would be better to don't have two asserts in one test, so every test will test other functionality. Now, I don't see any benefit for such approach in this case. I will make one test.
|
recheckcla |
|
Jina CLA check ✅ All Contributors have signed the CLA. |
|
@bio-howard Thanks for the contribution! To merge it you need to sign the CLA as stated above. |
|
I have read the CLA Document and I hereby sign the CLA. |
|
recheckcla |
No description provided.