Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add jina version info to docker image name #1341

Merged
merged 1 commit into from
Nov 25, 2020
Merged

fix: add jina version info to docker image name #1341

merged 1 commit into from
Nov 25, 2020

Conversation

cristianmtr
Copy link
Contributor

@cristianmtr cristianmtr commented Nov 24, 2020 •
edited
Loading

@cristianmtr cristianmtr requested a review from a team as a code owner November 24, 2020 10:26
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/docker labels Nov 24, 2020
@cristianmtr cristianmtr mentioned this pull request Nov 24, 2020
Closed
@cristianmtr cristianmtr force-pushed the fix-add-jina-version-to-hub-name branch from ae9d7fc to 5d7440e Compare November 24, 2020 10:28
@cristianmtr cristianmtr force-pushed the fix-add-jina-version-to-hub-name branch from 5d7440e to 2e85c70 Compare November 24, 2020 10:30
bwanglzu
bwanglzu previously approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanxiao
Copy link
Member

hanxiao commented Nov 25, 2020

@cristianmtr seems this integration test is broken

FAILED tests/integration/hub_usage/test_hub_usage.py::test_use_from_local_dir_flow_container_level

rutujasurve94
rutujasurve94 previously approved these changes Nov 25, 2020
View reviewed changes
@rutujasurve94
Copy link
Contributor

Let's fix the integration test and we are good to merge

@cristianmtr cristianmtr force-pushed the fix-add-jina-version-to-hub-name branch from 2e85c70 to f7b45c2 Compare November 25, 2020 09:52
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Nov 25, 2020
@cristianmtr
Copy link
Contributor Author

Oh missed that . Submitted a fix and rerunning now

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1341 (f7b45c2) into master (895112e) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   83.37%   83.02%   -0.36%     
==========================================
  Files         101      103       +2     
  Lines        6705     6814     +109     
==========================================
+ Hits         5590     5657      +67     
- Misses       1115     1157      +42
Impacted Files Coverage Δ
jina/docker/checker.py 82.14% <100.00%> (ø)
jina/docker/hubio.py 65.71% <100.00%> (-4.41%) ⬇️
jina/docker/hubapi.py 70.31% <0.00%> (-5.47%) ⬇️
jina/peapods/remote.py 45.78% <0.00%> (-4.91%) ⬇️
jina/types/request/__init__.py 91.89% <0.00%> (-4.15%) ⬇️
jina/types/document/uid.py 84.74% <0.00%> (-2.76%) ⬇️
jina/peapods/grpc_asyncio.py 75.51% <0.00%> (-1.03%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/jinad.py 54.36% <0.00%> (-0.37%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895112e...f7b45c2. Read the comment docs.

@cristianmtr
Copy link
Contributor Author

Integration test fixed now. But the codecov/project failed

JoanFM
JoanFM reviewed Nov 25, 2020
View reviewed changes
jina/docker/checker.py
@@ -68,7 +68,7 @@ def remove_control_characters(s):


def safe_url_name(s):
return s.lower().replace('-', '--').replace('_', '__').replace(' ', '_')
return s.lower().replace('_', '__').replace(' ', '_')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a unittest on what is expected here? why did we remove that part?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never used before and it was unnecessary (as discussed with @hanxiao ). The unittest in https://github.com/jina-ai/jina/pull/1341/files#diff-e63749458c2c70804a69ac37c0a560e869b070408233b988a219514a8df6cf31R55 covers it (the name format)

@bwanglzu
Copy link
Member

bwanglzu commented Nov 25, 2020 •
edited
Loading

@cristianmtr i guess you can ignore the coverage decrease for the time being, it's not related to your PR, it's related to the way we setup codecov. I'll look into this at night.

@hanxiao hanxiao merged commit d943849 into master Nov 25, 2020
@hanxiao hanxiao deleted the fix-add-jina-version-to-hub-name branch November 25, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark CatStark approved these changes

@bwanglzu bwanglzu bwanglzu approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@hanxiao hanxiao Awaiting requested review from hanxiao

@rutujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/docker size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cristianmtr @hanxiao @rutujasurve94 @bwanglzu @CatStark @JoanFM @jina-bot