refactor: moving log parse to core from jinad #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jina-bot
added
size/XS
area/core
JoanFM
reviewed
Nov 24, 2020
| @@ -189,6 +189,7 @@ async def wslogs(self, remote_id: 'str', stop_event: Event, current_line: int = | |||
| log_line = json.loads(log_line) | |||
| current_line = int(list(log_line.keys())[0]) | |||
| log_line_dict = list(log_line.values())[0] | |||
| log_line_dict = json.loads(log_line_dict.split('\t')[-1].strip()) | |||
There was a problem hiding this comment.
is this safe? can we add a try to default to simply the log_line_dict as it is?
There was a problem hiding this comment.
We've added a json.decoder.JSONDecodeError. Should be safe for now.
JoanFM
approved these changes
Nov 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 83.35% 83.40% +0.04%
==========================================
Files 101 101
Lines 6706 6707 +1
==========================================
+ Hits 5590 5594 +4
+ Misses 1116 1113 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.