-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(types): move add_chunk add_match to Set #1343
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
+ Coverage 83.25% 83.39% +0.14%
==========================================
Files 101 103 +2
Lines 6717 6812 +95
==========================================
+ Hits 5592 5681 +89
- Misses 1125 1131 +6
Continue to review full report at Codecov.
|
Right now, there are two functions for adding a chunk/match to the document. I'd suggest removing
with Document() as d:
c1 = d.chunks.append()
c1.id = f'1:0>16'
c2 = d.chunks.add()
c2.id = f'2:0>16' |
Breaking Change #1337
add_chunk
andadd_match
are removedDocument
with the newly introduced classes, includingUniqueId
,ChunkSet
,DocumentSet
,MatchSet