-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor index remote #1346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
==========================================
- Coverage 83.27% 83.19% -0.08%
==========================================
Files 103 103
Lines 6744 6744
==========================================
- Hits 5616 5611 -5
- Misses 1128 1133 +5
Continue to review full report at Codecov.
|
No comments from my side as I am not familiar with remote functionality |
tests/unit/test_index_remote.py
Outdated
f_args = set_gateway_parser().parse_args(['--allow-spawn']) | ||
time.sleep(3) | ||
for j in range(3): | ||
assert os.path.exists(f'test2-{j + 1}/test2.bin') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be using tmpdir?
@bhavsarpratik always keeps in mind jina is not for local environment, it is decentralized from day one. So remote feature is something MUST know especially for core develoeprs. |
@hanxiao True, I will spend time understanding the current features. |
@bwanglzu You can convert all path to pathlib path |
@bhavsarpratik nice proposal, I like it as well, shall we do it in a separate pr (for all the tests.)? |
--allow-spawn
(removed in refactor(proto): remove spawn request #1276 ).JinaTestCase
from__init__
, we're not using unittest anymore.