Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor index remote #1346

Merged
merged 5 commits into from
Nov 25, 2020
Merged

test: refactor index remote #1346

merged 5 commits into from
Nov 25, 2020

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Nov 24, 2020

  1. Removed index remote 2 from tests, since it testing the delete args --allow-spawn (removed in refactor(proto): remove spawn request #1276 ).
  2. Refactor index remote test.
  3. Remove JinaTestCase from __init__, we're not using unittest anymore.

@bwanglzu bwanglzu requested a review from a team as a code owner November 24, 2020 23:02
@bwanglzu bwanglzu self-assigned this Nov 24, 2020
@jina-bot jina-bot added size/M area/testing This issue/PR affects testing labels Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1346 (44e085f) into master (f8db230) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
- Coverage   83.27%   83.19%   -0.08%     
==========================================
  Files         103      103              
  Lines        6744     6744              
==========================================
- Hits         5616     5611       -5     
- Misses       1128     1133       +5     
Impacted Files Coverage Δ
jina/peapods/grpc_asyncio.py 75.51% <0.00%> (-5.11%) ⬇️
jina/peapods/container.py 88.40% <0.00%> (-2.90%) ⬇️
jina/drivers/querylang/select.py 86.20% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8db230...44e085f. Read the comment docs.

@bhavsarpratik
Copy link
Contributor

No comments from my side as I am not familiar with remote functionality

f_args = set_gateway_parser().parse_args(['--allow-spawn'])
time.sleep(3)
for j in range(3):
assert os.path.exists(f'test2-{j + 1}/test2.bin')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using tmpdir?

@hanxiao
Copy link
Member

hanxiao commented Nov 25, 2020

No comments from my side as I am not familiar with remote functionality

@bhavsarpratik always keeps in mind jina is not for local environment, it is decentralized from day one. So remote feature is something MUST know especially for core develoeprs.

@bhavsarpratik
Copy link
Contributor

@hanxiao True, I will spend time understanding the current features.

@bhavsarpratik
Copy link
Contributor

@bwanglzu You can convert all path to pathlib path

@bwanglzu
Copy link
Member Author

bwanglzu commented Nov 25, 2020

@bhavsarpratik nice proposal, I like it as well, shall we do it in a separate pr (for all the tests.)?

@hanxiao hanxiao merged commit ac38ebf into master Nov 25, 2020
@hanxiao hanxiao deleted the test-refactor-index-remote branch November 25, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants