Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make load config static #1354

Merged
merged 1 commit into from
Nov 26, 2020
Merged

fix: make load config static #1354

merged 1 commit into from
Nov 26, 2020

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/flow labels Nov 25, 2020
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use many more staticmethods in many plaes

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1354 (782c1ac) into master (ed81dd3) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   82.90%   83.00%   +0.09%     
==========================================
  Files         103      103              
  Lines        6746     6814      +68     
==========================================
+ Hits         5593     5656      +63     
- Misses       1153     1158       +5     
Impacted Files Coverage Δ
jina/logging/sse.py 92.64% <0.00%> (-2.52%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/pea.py 92.11% <0.00%> (-0.34%) ⬇️
jina/peapods/pod.py 82.89% <0.00%> (-0.10%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
jina/executors/evaluators/rank/precision.py 100.00% <0.00%> (ø)
jina/types/document/__init__.py 96.87% <0.00%> (+0.01%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed81dd3...127defb. Read the comment docs.

@hanxiao hanxiao marked this pull request as ready for review November 26, 2020 08:01
@hanxiao hanxiao requested a review from a team as a code owner November 26, 2020 08:01
@hanxiao hanxiao merged commit e122348 into master Nov 26, 2020
@hanxiao hanxiao deleted the fix-flow-load-is-static branch November 26, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/flow size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants