test: replace all random docs with new api #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1356 +/- ##
==========================================
+ Coverage 82.95% 83.01% +0.05%
==========================================
Files 103 103
Lines 6746 6746
==========================================
+ Hits 5596 5600 +4
+ Misses 1150 1146 -4
Continue to review full report at Codecov.
|
JoanFM
requested changes
Nov 27, 2020
tests/unit/yaml/test-index.yml
Outdated
| @@ -3,7 +3,7 @@ with: | |||
| index_filename: tmp2 | |||
| metas: | |||
| name: test2 | |||
| workspace: $JINA_TEST_INDEX | |||
| workspace: $TEST_WORKDIR | |||
There was a problem hiding this comment.
We arr trying to set the habit to prefix env variablws with JINA so please keep it as it was
hanxiao
reviewed
Nov 27, 2020
| @@ -49,7 +49,7 @@ def __getitem__(self, item): | |||
| if isinstance(item, int): | |||
| return Document(self._docs_proto[item]) | |||
| elif isinstance(item, str): | |||
| return Document(self._docs_map[str(item)]) | |||
There was a problem hiding this comment.
this is required, as UniqueId can not be directly used as a string
There was a problem hiding this comment.
oh but the test doesn't complain 🤔
There was a problem hiding this comment.
@hanxiao this is what I got in terminal
hanxiao
approved these changes
Nov 27, 2020
This was referenced Nov 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random_docswithrandom_docs_new_api, and ranamerandom_docs_new_apitorandom_docs. (didn't turn it into a conftest fixture since it has a lot of parameters)tmpdir.DocumentSettest. During refactoring, fixed some bugs inDocumentSet.What has been fixed in
DocumentSet:__setitem__callsCopyFrom, which expect to receive aDocument, passedDocument.as_pb_object.__setitem__for string object not setting, but returning.__getitem__whenisinstance(key, str), we convert the value into a string.