Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changes to test levels for hubio #1361

Merged
merged 4 commits into from
Dec 9, 2020
Merged

fix: changes to test levels for hubio #1361

merged 4 commits into from
Dec 9, 2020

Conversation

rutujasurve94
Copy link
Contributor

  • Changes to logic of _test_build in HubIO : returns failed test levels

  • Determine if build is successful or not depending on the level of test failure returned.

@rutujasurve94 rutujasurve94 requested a review from a team as a code owner November 26, 2020 12:32
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/docker labels Nov 26, 2020
@rutujasurve94 rutujasurve94 marked this pull request as draft November 26, 2020 12:34
@rutujasurve94 rutujasurve94 mentioned this pull request Nov 26, 2020
Closed
JoanFM
JoanFM requested changes Nov 26, 2020
View reviewed changes
jina/docker/hubio.py Outdated Show resolved Hide resolved
JoanFM
JoanFM reviewed Nov 27, 2020
View reviewed changes
jina/docker/hubio.py Outdated Show resolved Hide resolved
@rutujasurve94 rutujasurve94 force-pushed the fix-module-error branch 2 times, most recently from 965bdf7 to edeacb7 Compare November 27, 2020 08:23
@jina-bot jina-bot added the area/testing This issue/PR affects testing label Dec 7, 2020
JoanFM
JoanFM requested changes Dec 7, 2020
View reviewed changes
tests/unit/docker/test_hub_build_level.py Outdated Show resolved Hide resolved
tests/unit/docker/test_hub_build_level.py Outdated Show resolved Hide resolved
JoanFM
JoanFM requested changes Dec 7, 2020
View reviewed changes
tests/unit/docker/test_hub_build_level.py Outdated Show resolved Hide resolved
JoanFM
JoanFM reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss a test that checks the logic of setting build_success depending on the failed_levels

@rutujasurve94 rutujasurve94 force-pushed the fix-module-error branch 2 times, most recently from 4191b29 to ebc52a4 Compare December 9, 2020 11:57
@jina-bot jina-bot added size/M and removed size/S labels Dec 9, 2020
JoanFM
JoanFM previously approved these changes Dec 9, 2020
View reviewed changes
@jina-bot jina-bot added size/S and removed size/M labels Dec 9, 2020
@rutujasurve94 rutujasurve94 marked this pull request as ready for review December 9, 2020 12:03
@jina-bot jina-bot added size/M and removed size/S labels Dec 9, 2020
@jina-bot jina-bot added size/S and removed size/M labels Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1361 (1f3a1a5) into master (11f7222) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   82.37%   82.33%   -0.05%     
==========================================
  Files         105      105              
  Lines        7060     7077      +17     
==========================================
+ Hits         5816     5827      +11     
- Misses       1244     1250       +6
Impacted Files Coverage Δ
jina/docker/hubio.py 71.91% <100.00%> (-0.07%) ⬇️
jina/clients/python/grpc.py 69.84% <0.00%> (-11.12%) ⬇️
jina/peapods/zmq.py 82.02% <0.00%> (-1.97%) ⬇️
jina/peapods/pea.py 90.57% <0.00%> (+0.72%) ⬆️
jina/logging/sse.py 95.16% <0.00%> (+3.22%) ⬆️
jina/peapods/container.py 89.62% <0.00%> (+3.77%) ⬆️
jina/peapods/gateway/grpc.py 84.61% <0.00%> (+3.84%) ⬆️
jina/drivers/querylang/select.py 86.20% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f7222...ea9fa86. Read the comment docs.

@JoanFM JoanFM merged commit 7a0279b into master Dec 9, 2020
@JoanFM JoanFM deleted the fix-module-error branch December 9, 2020 18:19
This was referenced Dec 15, 2020
Closed
Closed
hanxiao
hanxiao reviewed Dec 31, 2020
View reviewed changes
Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is completely misleading and it is unclear what this PR is about.

tests/unit/docker/test_hub_build_level.py Show resolved Hide resolved
@hanxiao hanxiao mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang left review comments

@hanxiao hanxiao hanxiao left review comments

@JoanFM JoanFM JoanFM approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/docker size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rutujasurve94 @hanxiao @nan-wang @JoanFM @jina-bot