Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kvindexers): update method for binary pb indexer #1380

Merged
merged 12 commits into from
Dec 8, 2020
Merged

feat(kvindexers): update method for binary pb indexer #1380

merged 12 commits into from
Dec 8, 2020

Conversation

florian-hoenicke
Copy link
Member

Related ticket:
https://jinaai.atlassian.net/browse/JINACORE-483

Adding update and delete operations for all key value indexers.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/executor executor/indexer labels Dec 1, 2020
CatStark
CatStark previously approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@CatStark CatStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #1380 (c3f716c) into master (41cc787) will decrease coverage by 0.56%.
The diff coverage is 87.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
- Coverage   83.52%   82.95%   -0.57%     
==========================================
  Files         103      104       +1     
  Lines        6793     6959     +166     
==========================================
+ Hits         5674     5773      +99     
- Misses       1119     1186      +67
Impacted Files Coverage Δ
jina/types/document/__init__.py 92.33% <53.57%> (-4.98%) ⬇️
jina/drivers/encode.py 88.23% <66.66%> (-0.66%) ⬇️
jina/drivers/index.py 94.73% <66.66%> (-0.27%) ⬇️
jina/drivers/predict.py 89.83% <66.66%> (-0.17%) ⬇️
jina/drivers/search.py 94.64% <75.00%> (-0.10%) ⬇️
jina/types/sets/chunk_set.py 91.66% <84.61%> (-8.34%) ⬇️
jina/types/sets/match_set.py 95.83% <92.85%> (-4.17%) ⬇️
jina/types/sets/document_set.py 96.47% <93.93%> (-1.78%) ⬇️
jina/types/document/multimodal.py 97.91% <97.91%> (ø)
jina/docker/hubio.py 63.15% <100.00%> (-7.84%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111d72e...e318088. Read the comment docs.

hanxiao
hanxiao previously requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Dec 1, 2020
@cristianmtr cristianmtr force-pushed the feat-kvindexers-update-delete branch 6 times, most recently from 5b6eb6b to 3baaf6a Compare December 1, 2020 16:51
@jina-bot jina-bot added size/M and removed size/S labels Dec 2, 2020
@cristianmtr cristianmtr mentioned this pull request Dec 2, 2020
Merged
cristianmtr
cristianmtr previously approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@cristianmtr cristianmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Any other feedback? We should merge this

JoanFM
JoanFM requested changes Dec 7, 2020
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot merge this, you have done some updates to the hub submoudle that should not be there.

@cristianmtr
Copy link
Contributor

cristianmtr commented Dec 7, 2020 •
edited
Loading

We cannot merge this, you have done some updates to the hub submoudle that should not be there.

Not sure how that happened, but removed.

JoanFM
JoanFM previously approved these changes Dec 7, 2020
View reviewed changes
bwanglzu
bwanglzu previously approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if you can remove the unused tmpdirs.

@cristianmtr cristianmtr dismissed stale reviews from bwanglzu and JoanFM via e318088 December 7, 2020 11:09
@cristianmtr
Copy link
Contributor

lgtm if you can remove the unused tmpdirs.

Done, removed

bwanglzu
bwanglzu approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cristianmtr cristianmtr mentioned this pull request Dec 8, 2020
Closed
@cristianmtr cristianmtr merged commit 4ff0255 into master Dec 8, 2020
@cristianmtr cristianmtr deleted the feat-kvindexers-update-delete branch December 8, 2020 11:48
@nan-wang nan-wang added this to the v0.9 New Features milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr cristianmtr left review comments

@hanxiao hanxiao Awaiting requested review from hanxiao

@CatStark CatStark Awaiting requested review from CatStark

@nan-wang nan-wang Awaiting requested review from nan-wang

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@bwanglzu bwanglzu Awaiting requested review from bwanglzu

@bhavsarpratik bhavsarpratik Awaiting requested review from bhavsarpratik

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/indexer size/M
Projects
None yet
Milestone
v0.9 New Features
Development

Successfully merging this pull request may close these issues.
10 participants
@florian-hoenicke @JoanFM @cristianmtr @hanxiao @CatStark @nan-wang @maximilianwerk @bwanglzu @bhavsarpratik @jina-bot