Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): refactor docset.append method #1399

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 4, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 4, 2020 13:11
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1399 (b56dc4d) into master (20a77d5) will increase coverage by 0.06%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
+ Coverage   83.42%   83.49%   +0.06%     
==========================================
  Files         104      104              
  Lines        6860     6919      +59     
==========================================
+ Hits         5723     5777      +54     
- Misses       1137     1142       +5     
Impacted Files Coverage Δ
jina/types/document/__init__.py 92.27% <66.66%> (-0.29%) ⬇️
jina/types/sets/chunk_set.py 100.00% <100.00%> (ø)
jina/types/sets/document_set.py 96.47% <100.00%> (+0.12%) ⬆️
jina/types/sets/match_set.py 100.00% <100.00%> (ø)
jina/peapods/grpc_asyncio.py 79.59% <0.00%> (-2.05%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/pod.py 83.18% <0.00%> (-0.10%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed9857...b56dc4d. Read the comment docs.

@hanxiao hanxiao merged commit 6740433 into master Dec 4, 2020
@hanxiao hanxiao deleted the refactor-docset-append branch December 4, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants