Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check jina version in hub modules when pushing #1403

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

cristianmtr
Copy link
Contributor

  • Add --no-overwrite option to not allow pushing image with same module version and jina version

@cristianmtr cristianmtr requested a review from a team as a code owner December 7, 2020 08:53
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/docker labels Dec 7, 2020
@cristianmtr cristianmtr force-pushed the fix-dont-overwrite-docker-addendum branch 2 times, most recently from 28d3c58 to c66acc7 Compare December 7, 2020 10:29
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1403 (ef1b2f5) into master (9de90e6) will decrease coverage by 0.87%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1403      +/-   ##
==========================================
- Coverage   83.33%   82.46%   -0.88%     
==========================================
  Files         104      107       +3     
  Lines        6869     7081     +212     
==========================================
+ Hits         5724     5839     +115     
- Misses       1145     1242      +97     
Impacted Files Coverage Δ
jina/docker/hubio.py 71.97% <90.00%> (+1.06%) ⬆️
jina/excepts.py 100.00% <100.00%> (ø)
jina/parser.py 86.01% <100.00%> (+0.04%) ⬆️
jina/peapods/grpc_asyncio.py 0.00% <0.00%> (-75.52%) ⬇️
jina/types/ndarray/dense/numpy.py 97.36% <0.00%> (-2.64%) ⬇️
jina/logging/sse.py 92.64% <0.00%> (-2.52%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/pod.py 83.23% <0.00%> (-0.05%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136da67...ef1b2f5. Read the comment docs.

@cristianmtr cristianmtr force-pushed the fix-dont-overwrite-docker-addendum branch from c66acc7 to ef1b2f5 Compare December 8, 2020 07:59
@cristianmtr cristianmtr merged commit 8e6750a into master Dec 8, 2020
@cristianmtr cristianmtr deleted the fix-dont-overwrite-docker-addendum branch December 8, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/docker size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants