Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): event loop for rest server #1408

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

deepankarm
Copy link
Contributor

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner December 7, 2020 12:26
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/client component/peapod labels Dec 7, 2020
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests can be added to validate this?

@deepankarm
Copy link
Contributor Author

No tests can be added to validate this?

I need to think about tests for this, as this is complex. will work on this, while solving issues with pytest.asyncio

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1408 (9f8c8da) into master (130dfbb) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1408      +/-   ##
==========================================
- Coverage   81.91%   81.73%   -0.19%     
==========================================
  Files         106      106              
  Lines        6980     6970      -10     
==========================================
- Hits         5718     5697      -21     
- Misses       1262     1273      +11     
Impacted Files Coverage Δ
jina/clients/python/grpc.py 69.84% <ø> (-3.40%) ⬇️
jina/peapods/gateway/grpc.py 85.07% <100.00%> (-0.85%) ⬇️
jina/peapods/gateway/rest.py 89.23% <100.00%> (+0.34%) ⬆️
jina/logging/sse.py 91.93% <0.00%> (-3.23%) ⬇️
jina/peapods/container.py 88.17% <0.00%> (-2.16%) ⬇️
jina/peapods/zmq.py 82.51% <0.00%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130dfbb...00eb76f. Read the comment docs.

@hanxiao hanxiao merged commit af36ae6 into master Dec 7, 2020
@hanxiao hanxiao deleted the fix-rest-gateway-jinad branch December 7, 2020 13:33
@nan-wang nan-wang added this to the v0.9 New Features milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/client component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants