Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add opname when ranking #1409

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: add opname when ranking #1409

merged 1 commit into from
Dec 7, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 7, 2020

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner December 7, 2020 14:49
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver labels Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1409 (13cfef4) into master (af36ae6) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
+ Coverage   81.89%   81.96%   +0.07%     
==========================================
  Files         106      106              
  Lines        6970     7042      +72     
==========================================
+ Hits         5708     5772      +64     
- Misses       1262     1270       +8     
Impacted Files Coverage Δ
jina/drivers/rank.py 97.29% <100.00%> (+0.07%) ⬆️
jina/clients/python/grpc.py 69.84% <0.00%> (-11.12%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/pod.py 83.23% <0.00%> (-0.10%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
jina/executors/evaluators/rank/precision.py 100.00% <0.00%> (ø)
jina/peapods/pea.py 92.88% <0.00%> (+0.02%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af36ae6...13cfef4. Read the comment docs.

Copy link
Contributor

@cristianmtr cristianmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JoanFM JoanFM merged commit ce258b1 into master Dec 7, 2020
@JoanFM JoanFM deleted the fix-add-op-name-ranker branch December 7, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants