Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor type sets test #1417

Merged
merged 4 commits into from
Dec 9, 2020
Merged

test: refactor type sets test #1417

merged 4 commits into from
Dec 9, 2020

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Dec 8, 2020

This PR do 2 things:

  1. Move all chunkset, documentset, and matchset into set folder.
  2. Experimentation, create an empty test_querylangset.py with pre-defined methods and docstrings, try to attract community members contribute to this piece of test. cc @alexcg1 @pswu11

The idea comes from @bio-howard :

  1. Structure tests.
  2. Fill docstrings.
  3. Define new test cases and open good first issue tasks.

@bwanglzu bwanglzu self-assigned this Dec 8, 2020
@bwanglzu bwanglzu requested a review from a team as a code owner December 8, 2020 22:47
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #1417 (b237d5b) into master (0094bbf) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   82.21%   82.30%   +0.08%     
==========================================
  Files         106      105       -1     
  Lines        7064     7060       -4     
==========================================
+ Hits         5808     5811       +3     
+ Misses       1256     1249       -7     
Impacted Files Coverage Δ
jina/drivers/querylang/select.py 79.31% <0.00%> (-6.90%) ⬇️
jina/types/document/__init__.py 92.27% <0.00%> (ø)
jina/types/sets/__init__.py
jina/peapods/zmq.py 83.98% <0.00%> (+1.96%) ⬆️
jina/logging/sse.py 95.16% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0094bbf...b237d5b. Read the comment docs.

@bwanglzu bwanglzu merged commit ad81b05 into master Dec 9, 2020
@bwanglzu bwanglzu deleted the test-add-querylang-set branch December 9, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants