New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add named score type #1430
Conversation
why not
and you get all these getters setters for free (as far as I know you didn't use |
I like the idea; however my idea is to have a baseline to eventually support everything the Proto class accepts |
848233a
to
5e70768
Compare
ccaf8d5
to
7ebc1c6
Compare
7ebc1c6
to
6ddb8cd
Compare
e1da17f
to
32e5efb
Compare
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
f0deb10
to
04e0de2
Compare
17ba878
to
943dbb6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
==========================================
+ Coverage 84.07% 84.26% +0.19%
==========================================
Files 106 106
Lines 6102 6158 +56
==========================================
+ Hits 5130 5189 +59
+ Misses 972 969 -3
Continue to review full report at Codecov.
|
a0dbd8b
to
ff67b4c
Compare
Thanks for your contribution ❤️ Note, other CI tests will not start until the commit messages get fixed. This message will be deleted automatically when the commit messages get fixed. |
Changes introduced
Add NamedScore type and set a property for document.
Useful to provide
expected
score values for groundtruth specially for NDCGEvaluationFixes #1431